Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not compile different shader for opacity of 1 and diffuse tint of white #6721

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Do not compile different shader for opacity of 1 and diffuse tint of white #6721

merged 1 commit into from
Jun 19, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jun 19, 2024 •
edited
Loading

Fixes #6184

  • when the opacity is 1, or diffuse is white, do not exclude their handling from the generated shader, to avoid new shader when those values change from the default.
  • there is a small cost of a uniform being set and the tint applied, but that is very small.
  • note that emissive tint already handles this
@mvaligursky mvaligursky self-assigned this Jun 19, 2024
@mvaligursky mvaligursky added performance Relating to load times or frame rate area: graphics Graphics related issue labels Jun 19, 2024
@mvaligursky mvaligursky requested a review from a team June 19, 2024 13:55
@mvaligursky mvaligursky merged commit 1d09168 into main Jun 19, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-tint-cleanup branch June 19, 2024 14:05
mvaligursky added a commit that referenced this pull request Jun 19, 2024
@mvaligursky
Do not compile different shader for opacity of 1 and diffuse tint of …
a08e804 
…white (#6721)

Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
@mvaligursky mvaligursky mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue performance Relating to load times or frame rate
2 participants
@mvaligursky @willeastcott