Standard material handles textures in sRGB format #6736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+979
to
+991
| [PIXELFORMAT_DXT1, { name: 'DXT1', blockSize: 8, srgb: true }], | ||
| [PIXELFORMAT_DXT3, { name: 'DXT3', blockSize: 16, srgb: true }], | ||
| [PIXELFORMAT_DXT5, { name: 'DXT5', blockSize: 16, srgb: true }], | ||
| [PIXELFORMAT_ETC1, { name: 'ETC1', blockSize: 8, srgb: true }], | ||
| [PIXELFORMAT_ETC2_RGB, { name: 'ETC2_RGB', blockSize: 8, srgb: true }], | ||
| [PIXELFORMAT_ETC2_RGBA, { name: 'ETC2_RGBA', blockSize: 16, srgb: true }], | ||
| [PIXELFORMAT_PVRTC_2BPP_RGB_1, { name: 'PVRTC_2BPP_RGB_1', blockSize: 8, srgb: true }], | ||
| [PIXELFORMAT_PVRTC_2BPP_RGBA_1, { name: 'PVRTC_2BPP_RGBA_1', blockSize: 8, srgb: true }], | ||
| [PIXELFORMAT_PVRTC_4BPP_RGB_1, { name: 'PVRTC_4BPP_RGB_1', blockSize: 8, srgb: true }], | ||
| [PIXELFORMAT_PVRTC_4BPP_RGBA_1, { name: 'PVRTC_4BPP_RGBA_1', blockSize: 8, srgb: true }], | ||
| [PIXELFORMAT_ASTC_4x4, { name: 'ASTC_4x4', blockSize: 16, srgb: true }], | ||
| [PIXELFORMAT_ATC_RGB, { name: 'ATC_RGB', blockSize: 8, srgb: true }], | ||
| [PIXELFORMAT_ATC_RGBA, { name: 'ATC_RGBA', blockSize: 16, srgb: true }], |
There was a problem hiding this comment.
Wait, they're all SRGB all the time? Can't I have a linear normal map, say, using these compressed formats?
There was a problem hiding this comment.
these we convert to linear manually.
Soon I'll add compressed texture formats stored in sRGB as well, separate PR.
willeastcott
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RGB8andRGBA8formats, as they're the same but in addition handles sRGB conversion:Added support for SRGBA8 on WebGPU
When standard material uses a texture in sRGB space, we skip in-shader conversion of sRGB->linear, as sampling it gives us a linear value already.