Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScriptAttribute fix #6750

Merged
merged 4 commits into from
Jun 25, 2024
Merged

ScriptAttribute fix #6750

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f494258
Added guard around attribute assignment. Exposes attrToValue as stati…
marklundin Jun 25, 2024
9eea744
Merge branch 'main' into attrib-value-export
marklundin Jun 25, 2024
1097d9a
linting fixes
marklundin Jun 25, 2024
718efd2
Merge branch 'attrib-value-export' of https://github.com/playcanvas/e…
marklundin Jun 25, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linting fixes
  • Loading branch information
@marklundin
marklundin committed Jun 25, 2024
commit 1097d9aeb2199968f30d1a33c65421525c994bc7
5 changes: 3 additions & 2 deletions src/framework/script/script-attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,15 +180,15 @@ function attributeToValue(app, schema, value, current) {
*/
export function assignAttributesToScript(app, attributeSchemaMap, data, script) {

if(!data) return;
if (!data) return;

// Iterate over the schema and assign corresponding data
for (const attributeName in attributeSchemaMap) {
const attributeSchema = attributeSchemaMap[attributeName];
const dataToAssign = data[attributeName];

// Skip if the data is not defined
if(dataToAssign === undefined) continue;
if (dataToAssign === undefined) continue;

// Assign the value to the script based on the attribute schema
script[attributeName] = attributeToValue(app, attributeSchema, dataToAssign, script[attributeName]);
Expand All @@ -204,6 +204,7 @@ export function assignAttributesToScript(app, attributeSchemaMap, data, script)
*/
class ScriptAttributes {
static assignAttributesToScript = assignAttributesToScript;

static attributeToValue = attributeToValue;

/**
Expand Down