WebXR - fix depth sensing on quest 3 #6774
Merged
+18
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can a fix be achieved without sniffing the user agent? I'm not a big fan of doing that... |
Unfortunately, I'm not aware of other ways of detecting Quest browser.
It is somewhat weird behaviour currently, I will definitely raise an issue with their implementation, but currently it fixes a problem. Maybe they will improve it in the future. |
|
OK. Well, I'll approve + merge for now, but we should return to this at a later date... |
willeastcott
approved these changes
Jul 2, 2024
willeastcott
pushed a commit
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent update of OculusBrowser depth sensing implementation broke access to it.
There was an update to the WebXR Depth Sensing specs and implementation of it on Meta Quest: immersive-web/depth-sensing#49
This PR ensures that we take that edge case into account.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.