refactor(types): dynamically map OGLElements #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors type enhancements from pmndrs/react-three-fiber#2465.
Dynamically mapped OGLElements
Additionally, OGL types for
JSX.IntrinsicElements
are no longer hard-coded and dynamically mapped toOGLElements
. This lets us properly follow semver once@types/ogl
is upstreamed.Node => OGLElement
The
Node
interface has been simplified and renamed toOGLElement
to prevent clashing with DOM types: