fix: safely import legacy act for Next #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/reconciler.ts
Outdated
| export const act: Act = (React as any).unstable_act | ||
| export const act: Act = (React as any)?.unstable_act |
There was a problem hiding this comment.
I don't think this would actually work for your version. Can you try this instead?
export const act: Act = (React as any)?.unstable_act ?? (React as any)?.act
The method is called like await act(async () => {}) which forces React to recursively flush work.
There was a problem hiding this comment.
Your suggestion worked too + looks more correct. I know nothing about React internals 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced this error using nextjs on react 18. Adding the optional chaining operator seems to fix it.