-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite node module handling (npm plugin) #874
Draft
marvinhagemeister
wants to merge
41
commits into
main
Choose a base branch
from
npm-refactor2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
f3fbb1b
Add foundation for a new npm plugin
marvinhagemeister fde2f51
Acorn: Add missing exportDefaultDeclaration
marvinhagemeister 5908aed
Add support for commonjs default exports
marvinhagemeister 4682b9e
Add support for legacy sub packages
marvinhagemeister f1dee81
Add support for auto installing npm dependencies
marvinhagemeister 46bb3f2
Add basic support for "exports" field
marvinhagemeister bd516a1
Fix unable to resolve scoped packages
marvinhagemeister 7624518
Watcher: Ignore `.cache/` folder
marvinhagemeister 34c4f08
Cleanup npm-plugin logging
marvinhagemeister 4f153e8
Experiment with npm autoInstall
marvinhagemeister 7b52e2c
Fix incorrect npm auto-install cache directory
marvinhagemeister da3bb3b
Fix commonjs rewriting non "module.exports" assginments
marvinhagemeister ad65d49
Add support for commonjs proxy modules
marvinhagemeister 2139c51
Fix duplicate download requeusts
marvinhagemeister ac47f47
Drop if-statement if it's unreachable
marvinhagemeister cea027b
Remove single top level IIFE in CommonJS bundles
marvinhagemeister 121c772
Switch to a non-string based transpiler for commonjs
marvinhagemeister 560c362
Fix CommonJS file not being detected
marvinhagemeister 86ce5cb
Include json in npm bundles
marvinhagemeister a0aa34a
Improve npm module bundling
marvinhagemeister 9b1d76e
NPM: Bring back disk cache
marvinhagemeister 31419e6
Update to zecorn 0.8.1
marvinhagemeister d5b5a2a
Use `writeFile` helper
marvinhagemeister 7aa7999
Remove `setCwd` hack
marvinhagemeister 1862bbf
Fix unable to load json in commonjs package
marvinhagemeister 65104d9
NPM: Remove file dependencies on old plugin
marvinhagemeister b8dd4ac
NPM: Support loading assets from node modules
marvinhagemeister 944d74e
NPM: Add back size warning plugin
marvinhagemeister 4a13701
NPM: Remove old npm plugin
marvinhagemeister c2adc8a
Bring back etag caching for npm packages
marvinhagemeister b791f9b
Upgrade zecorn to fix codegen issues
marvinhagemeister 300d7fc
Allow loading assets from auto-installed packages
marvinhagemeister 755826e
NPM: Use already extracted package if available
marvinhagemeister ee489af
Support auto installing versioned packages
marvinhagemeister 151def0
Fix incorrect CLI argument casing
marvinhagemeister a9e22b7
Specify custom npm registry via `--registry`
marvinhagemeister efe3a9e
Add changeset
marvinhagemeister bedc4da
NPM: Default to `index.js` if no entry point is found
marvinhagemeister 52950ec
Update zecorn to 0.9.5
marvinhagemeister bbe841c
Reduce test CLI noise
marvinhagemeister 3043967
WIP
marvinhagemeister File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
NPM: Use already extracted package if available
- Loading branch information
commit 755826ef642064836ce7635af45bb219e966a491
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like this could instead stream directly into parseTarball, to skip the disk write+read and cut memory usage in half.