Skip to content
This repository has been archived by the owner on Nov 16, 2020. It is now read-only.

All tags are gone!? #26

Open
WhyNotHugo opened this issue Nov 10, 2020 · 4 comments · Fixed by PyCQA/modernize#246
Open

All tags are gone!? #26

WhyNotHugo opened this issue Nov 10, 2020 · 4 comments · Fixed by PyCQA/modernize#246

Comments

@WhyNotHugo
Copy link

WhyNotHugo commented Nov 10, 2020 •
edited
Loading

All the release tags are gone.

This completely brakes existing integrations. It also breaks pre-commit autoupdate. Since there are no tags, the latest commit is picked up as the latest version:

-  - repo: https://github.com/prettier/prettier
-    rev: v2.1.2
+  - repo: https://github.com/prettier/pre-commit
+    rev: 413fd9da8e03249b74acf8543567e5debbad8bfa

I moved to using the pre-commit hook recently since prettier/prettier broke due to npm changes, but it seems this mirror is not broken too.
@graingert
Copy link

but it seems this mirror is not broken too.

it seems not not broken to me
@graingert
Copy link

this is also broken on pre-commit.ci where the environment is cached globally based on the revision, and so pushing to a branch won't update the code
@graingert
Copy link

@WhyNotHugo this is now fixed in https://github.com/pre-commit/mirrors-prettier
graingert added a commit to graingert/modernize that referenced this issue Nov 16, 2020
@graingert
upgrade to pre-commit/mirrors-prettier
166780d 
fixes prettier/pre-commit#26
fixes prettier/pre-commit#27
fixes prettier/pre-commit#23
fixes prettier/pre-commit#21
@graingert graingert mentioned this issue Nov 16, 2020
Merged
@WhyNotHugo
Copy link
Author

WhyNotHugo commented Nov 16, 2020 •
edited
Loading

Thanks, @graingert!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants
@graingert @WhyNotHugo