Skip to content

Commit

Permalink
Fix ColorTemperatureMireds naming to follow the spec. (#22237)
Browse files Browse the repository at this point in the history
* Fix ColorTemperatureMireds naming to follow the spec.

* Add backwards-compat hack for chip-tool.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Oct 9, 2023
1 parent 573aa76 commit 5053944
Show file tree
Hide file tree
Showing 77 changed files with 461 additions and 447 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2807,7 +2807,7 @@ server cluster ColorControl = 768 {
readonly attribute int16u currentY = 4;
readonly attribute enum8 driftCompensation = 5;
readonly attribute char_string<254> compensationText = 6;
readonly attribute int16u colorTemperature = 7;
readonly attribute int16u colorTemperatureMireds = 7;
readonly attribute enum8 colorMode = 8;
attribute bitmap8 options = 15;
readonly attribute nullable int8u numberOfPrimaries = 16;
Expand Down Expand Up @@ -4489,7 +4489,7 @@ endpoint 1 {
ram attribute currentY default = 0x607D;
ram attribute driftCompensation;
ram attribute compensationText;
ram attribute colorTemperature default = 0x00FA;
ram attribute colorTemperatureMireds default = 0x00FA;
ram attribute colorMode default = 0x01;
ram attribute options;
ram attribute numberOfPrimaries;
Expand Down
23 changes: 11 additions & 12 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,19 @@
}
],
"package": [
{
"pathRelativity": "relativeToZap",
"path": "../../../src/app/zap-templates/app-templates.json",
"type": "gen-templates-json",
"version": "chip-v1"
},
{
"pathRelativity": "relativeToZap",
"path": "../../../src/app/zap-templates/zcl/zcl-with-test-extensions.json",
"type": "zcl-properties",
"category": "matter",
"version": 1,
"description": "Matter SDK ZCL data with some extensions"
},
{
"pathRelativity": "relativeToZap",
"path": "../../../src/app/zap-templates/app-templates.json",
"type": "gen-templates-json",
"version": "chip-v1"
}
],
"endpointTypes": [
Expand Down Expand Up @@ -5459,7 +5459,7 @@
"code": 0,
"mfgCode": null,
"side": "server",
"type": "int8u",
"type": "CommissioningWindowStatus",
"included": 1,
"storageOption": "External",
"singleton": 0,
Expand Down Expand Up @@ -6869,7 +6869,7 @@
"reportableChange": 0
},
{
"name": "ColorTemperature",
"name": "ColorTemperatureMireds",
"code": 7,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -15721,7 +15721,7 @@
"reportableChange": 0
},
{
"name": "ColorTemperature",
"name": "ColorTemperatureMireds",
"code": 7,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -23403,7 +23403,7 @@
"reportableChange": 0
},
{
"name": "ColorTemperature",
"name": "ColorTemperatureMireds",
"code": 7,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -24724,6 +24724,5 @@
"endpointVersion": 1,
"deviceIdentifier": 61442
}
],
"log": []
]
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 77,
"featureLevel": 80,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -4673,7 +4673,7 @@
"reportableChange": 0
},
{
"name": "delay",
"name": "Delay",
"code": 58,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -4705,7 +4705,7 @@
"reportableChange": 0
},
{
"name": "ChannelMask",
"name": "ChannelPage0Mask",
"code": 60,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -5459,7 +5459,7 @@
"code": 0,
"mfgCode": null,
"side": "server",
"type": "int8u",
"type": "CommissioningWindowStatus",
"included": 1,
"storageOption": "External",
"singleton": 0,
Expand Down Expand Up @@ -6869,7 +6869,7 @@
"reportableChange": 0
},
{
"name": "ColorTemperature",
"name": "ColorTemperatureMireds",
"code": 7,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -15427,7 +15427,7 @@
"reportableChange": 0
},
{
"name": "ColorTemperature",
"name": "ColorTemperatureMireds",
"code": 7,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -23195,7 +23195,7 @@
"reportableChange": 0
},
{
"name": "ColorTemperature",
"name": "ColorTemperatureMireds",
"code": 7,
"mfgCode": null,
"side": "server",
Expand Down
10 changes: 5 additions & 5 deletions examples/bridge-app/bridge-common/bridge-app.zap
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 77,
"featureLevel": 80,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -3417,7 +3417,7 @@
"reportableChange": 0
},
{
"name": "delay",
"name": "Delay",
"code": 58,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -3449,7 +3449,7 @@
"reportableChange": 0
},
{
"name": "ChannelMask",
"name": "ChannelPage0Mask",
"code": 60,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -4109,7 +4109,7 @@
"code": 0,
"mfgCode": null,
"side": "server",
"type": "int8u",
"type": "CommissioningWindowStatus",
"included": 1,
"storageOption": "External",
"singleton": 0,
Expand Down Expand Up @@ -4946,7 +4946,7 @@
},
{
"name": "Anonymous Endpoint Type",
"deviceTypeName": "MA-bridge",
"deviceTypeName": "MA-aggregator",
"deviceTypeCode": 14,
"deviceTypeProfileId": 259,
"clusters": [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 77,
"featureLevel": 80,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -3817,7 +3817,7 @@
"reportableChange": 0
},
{
"name": "delay",
"name": "Delay",
"code": 58,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -3849,7 +3849,7 @@
"reportableChange": 0
},
{
"name": "ChannelMask",
"name": "ChannelPage0Mask",
"code": 60,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -4553,7 +4553,7 @@
"code": 0,
"mfgCode": null,
"side": "server",
"type": "int8u",
"type": "CommissioningWindowStatus",
"included": 1,
"storageOption": "External",
"singleton": 0,
Expand Down
8 changes: 4 additions & 4 deletions examples/chef/devices/rootnode_contactsensor_lFAGG1bfRO.zap
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 77,
"featureLevel": 80,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -3817,7 +3817,7 @@
"reportableChange": 0
},
{
"name": "delay",
"name": "Delay",
"code": 58,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -3849,7 +3849,7 @@
"reportableChange": 0
},
{
"name": "ChannelMask",
"name": "ChannelPage0Mask",
"code": 60,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -4553,7 +4553,7 @@
"code": 0,
"mfgCode": null,
"side": "server",
"type": "int8u",
"type": "CommissioningWindowStatus",
"included": 1,
"storageOption": "External",
"singleton": 0,
Expand Down
8 changes: 4 additions & 4 deletions examples/chef/devices/rootnode_dimmablelight_bCwGYSDpoe.zap
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 77,
"featureLevel": 80,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -3817,7 +3817,7 @@
"reportableChange": 0
},
{
"name": "delay",
"name": "Delay",
"code": 58,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -3849,7 +3849,7 @@
"reportableChange": 0
},
{
"name": "ChannelMask",
"name": "ChannelPage0Mask",
"code": 60,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -4553,7 +4553,7 @@
"code": 0,
"mfgCode": null,
"side": "server",
"type": "int8u",
"type": "CommissioningWindowStatus",
"included": 1,
"storageOption": "External",
"singleton": 0,
Expand Down
10 changes: 5 additions & 5 deletions examples/chef/devices/rootnode_doorlock_aNKYAreMXE.zap
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 77,
"featureLevel": 80,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -3817,7 +3817,7 @@
"reportableChange": 0
},
{
"name": "delay",
"name": "Delay",
"code": 58,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -3849,7 +3849,7 @@
"reportableChange": 0
},
{
"name": "ChannelMask",
"name": "ChannelPage0Mask",
"code": 60,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -4553,7 +4553,7 @@
"code": 0,
"mfgCode": null,
"side": "server",
"type": "int8u",
"type": "CommissioningWindowStatus",
"included": 1,
"storageOption": "External",
"singleton": 0,
Expand Down Expand Up @@ -7845,7 +7845,7 @@
"reportableChange": 0
},
{
"name": "ColorTemperature",
"name": "ColorTemperatureMireds",
"code": 7,
"mfgCode": null,
"side": "server",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1600,7 +1600,7 @@ server cluster ColorControl = 768 {
readonly attribute int16u remainingTime = 2;
readonly attribute int16u currentX = 3;
readonly attribute int16u currentY = 4;
readonly attribute int16u colorTemperature = 7;
readonly attribute int16u colorTemperatureMireds = 7;
readonly attribute enum8 colorMode = 8;
attribute bitmap8 options = 15;
readonly attribute int16u enhancedCurrentHue = 16384;
Expand Down Expand Up @@ -2000,7 +2000,7 @@ endpoint 1 {
ram attribute remainingTime;
ram attribute currentX default = 0x616B;
ram attribute currentY default = 0x607D;
ram attribute colorTemperature default = 0x00FA;
ram attribute colorTemperatureMireds default = 0x00FA;
ram attribute colorMode default = 0x01;
ram attribute options;
ram attribute enhancedCurrentHue;
Expand Down
10 changes: 5 additions & 5 deletions examples/chef/devices/rootnode_extendedcolorlight_8lcaaYJVAa.zap
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 77,
"featureLevel": 80,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -3817,7 +3817,7 @@
"reportableChange": 0
},
{
"name": "delay",
"name": "Delay",
"code": 58,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -3849,7 +3849,7 @@
"reportableChange": 0
},
{
"name": "ChannelMask",
"name": "ChannelPage0Mask",
"code": 60,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -4553,7 +4553,7 @@
"code": 0,
"mfgCode": null,
"side": "server",
"type": "int8u",
"type": "CommissioningWindowStatus",
"included": 1,
"storageOption": "External",
"singleton": 0,
Expand Down Expand Up @@ -7135,7 +7135,7 @@
"reportableChange": 0
},
{
"name": "ColorTemperature",
"name": "ColorTemperatureMireds",
"code": 7,
"mfgCode": null,
"side": "server",
Expand Down
Loading

0 comments on commit 5053944

Please sign in to comment.