[Infineon] Not to increment RebootCount if wakes from sleep state #26275
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
|
|
||
| err = StoreRebootCount(rebootCount + 1); | ||
| SuccessOrExit(err); | ||
| if (wiced_sleep_get_boot_mode() != WICED_SLEEP_FAST_BOOT) |
There was a problem hiding this comment.
Another question: when is PlatformMgrImpl().GetStartTime() being set, for purposes of GetUpTime? That one:
- Needs to match the reboot count bit
- Needs to match the time base for events.
There was a problem hiding this comment.
For the first question, we will save data into retention RAM before sleep. And it count as "wakes up from a sleep state".
For the second question, I think PlatformMgrImpl().GetStartTime() is for Linux specific, and we didn't implement it on our platform.
There was a problem hiding this comment.
@AlvinHsiao Which data is being saved into retention RAM?
I see that I just misread things and GetStartTime is relevant to Infineon/PSOC6, not Infineon/CYW30739, and that Infineon/CYW30739 just does not implement the UpTime attribute at all. Is that a correct description of the current situation?
And you're shutting down the Matter stack before entering the sleep state and restarting it when you exit?
There was a problem hiding this comment.
@bzbarsky-apple Yes, this is our temporary workaround to support sleepy end device.
There was a problem hiding this comment.
@HuangCC-IFX That doesn't quite answer my question around which data is persisted. For example, when you enter this sleep state, do you clear out the queued events in the Matter stack? Do you issue a new StartUp event when coming out and a ShutDown event when entering?
|
PR #26275: Size comparison from 328c553 to edbe4b4 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
pullapprove
bot
requested review from
hicklin,
mhazley,
p0fi,
plauric,
tima-q and
tobiasgraf
pullapprove
bot
requested review from
aronrosenberg,
cecille,
turon,
yufengwangca,
mkardous-silabs and
rcasallas-silabs
|
This stale pull request has been automatically closed. Thank you for your contributions. |
|
PR #26275: Size comparison from 7423b08 to edbe4b4 Increases (5 builds for bl702l, cyw30739)
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
RebootCount would increment if wakes from sleep state.
Change overview
Not to increment RebootCount if wakes from sleep state.
Testing
Tested manually with chip-tool.