Add APIs for non-commissioning device attestation to Matter.framework. #28595
+454
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #28595: Size comparison from a598efd to cf57642 Increases (6 builds for bl602, bl702, nrfconnect, telink)
Decreases (10 builds for efr32, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
andy31415
approved these changes
Aug 30, 2023
| }); | ||
| } | ||
|
|
||
| // Sure would be nice to have await/async. Try to avoid infinite completion |
There was a problem hiding this comment.
Maybe a more conventional way to avoid deep nesting would be to have a helper class holding the state for your async operation, and a separate method per step that looks something like
- (void)fetchVendorID {
[something doSomethingWithCompletion:^(...) {
if (error) {
[self handleError:error];
} else {
_vendorId = result;
[self fetchProductID];
}
}];
}
| - (void)verifyAttestationWithQueue:(dispatch_queue_t)queue completion:(MTRDeviceAttestationVerificationHandler)completion | ||
| { | ||
| auto * baseDevice = [self newBaseDevice]; | ||
| [baseDevice verifyAttestationWithQueue:queue completion:completion]; |
There was a problem hiding this comment.
If going with the helper class approach it could be directly created here be given the MTRBaseDevice, rather than having the code itself live inside MTRBaseDevice.
| - (instancetype)initWithDeviceAttestationChallenge:(NSData *)challenge | ||
| nonce:(NSData *)nonce | ||
| elementsTLV:(MTRTLVBytes)elementsTLV | ||
| elementsSignature:(NSData *)elementsSignature | ||
| deviceAttestationCertificate:(MTRCertificateDERBytes)deviceAttestationCertificate | ||
| productAttestationIntermediateCertificate:(MTRCertificateDERBytes)processAttestationIntermediateCertificate | ||
| certificationDeclaration:(NSData *)certificationDeclaration | ||
| firmwareInfo:(NSData *)firmwareInfo; | ||
| firmwareInfo:(NSData *)firmwareInfo | ||
| MTR_NEWLY_DEPRECATED("Please use the version with basicInformationVendorID and basicInformationProductID"); |
There was a problem hiding this comment.
Isn't this class an output of device attestation? If so, why is the initializer even public API?
There was a problem hiding this comment.
If so, why is the initializer even public API?
Because someone did that, we did insufficient review, an then we shipped it... I could make the new initializer not be public, @ksperling-apple
There was a problem hiding this comment.
Yeah just deprecate the current one without a replacement and make the new one internal?
Co-authored-by: Karsten Sperling <113487422+ksperling-apple@users.noreply.github.com>
Co-authored-by: Karsten Sperling <113487422+ksperling-apple@users.noreply.github.com>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
I still need to get back to the review comments on this and get it updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24709