add isLastElement in kotlin tlvReader #28617
Draft
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
mspang,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple and
younghak-hwang
yufengwangca
approved these changes
Aug 10, 2023
|
PR #28617: Size comparison from a3c4b48 to 29f0f4f Increases (11 builds for bl702, mbed, psoc6, telink)
Decreases (11 builds for bl702l, efr32, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Aug 10, 2023
| Tag.encode(value.toType().encode(), tag).size + value.encode().size | ||
|
|
||
| /** Returns true if this reader is currently pointing to the last element in the TLV data. */ | ||
| fun isLastElement(): Boolean { |
There was a problem hiding this comment.
can we use = here since function is trivial?
There was a problem hiding this comment.
This also seems to rely that decoding and re-encoding is the same size. Likely correct, but needs mental processing for this.
How about using the same logic as in peekElement (i.e. remembering the index) and checking if we reached the end index (i.e. index >= bytes.size)?
There was a problem hiding this comment.
This also seems to throw if you already read the entire tlv ... I would expect isLastElement to return true if the TLV is pointing to the last element and false otherwise. Instead this also has the case of will throw if reader points to the end/is exhausted which seems inconvenient.
What is the usage of this method? Why don't we have a wasLastElement maybe which is trivial?
@yunhanw-google could you add some description on why we do this rather than just describing that we do it? It seems trivial to have a |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add isLastElement in kotlin tlvReader and corresponding test