Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kotlin tests, remove unused code #32880

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix kotlin tests, remove unused code #32880

wants to merge 3 commits into from
+29 −30

Conversation

achaulk-goog
Copy link
Contributor

assertThat(false) doesn't actually do anything, it returns an object you can then make assertions against, use assertTrue instead

testQRCodeWithOptionalData relies upon an implicit ordering, however the underlying representation (HashMap) is unordered
@achaulk-goog
Fix kotlin tests, remove unused code
8ee054c 
assertThat(false) doesn't actually do anythung, it returns an object
you can then make assertions against, use assertTrue instead

testQRCodeWithOptionalData relied upon an implicit ordering, however
the underlying representation (HashMap) is unordered
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

PR #32880: Size comparison from 739923c to 8ee054c

Decreases (1 build for efr32)
platform target config section 739923c 8ee054c change % change
efr32 lock-app BRD4338a (read/write) 959936 959928 -8 -0.0
.text 700172 700164 -8 -0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 739923c 8ee054c change % change
bl602 lighting-app bl602 (read/write) 1442278 1442278 0 0.0
.bss 85432 85432 0 0.0
.data 9504 9504 0 0.0
.rodata 158976 158976 0 0.0
.text 1107698 1107698 0 0.0
bl602+mfd (read/write) 1456694 1456694 0 0.0
.bss 85600 85600 0 0.0
.data 9480 9480 0 0.0
.rodata 157936 157936 0 0.0
.text 1123016 1123016 0 0.0
bl602+rpc (read/write) 1489918 1489918 0 0.0
.bss 93480 93480 0 0.0
.data 9880 9880 0 0.0
.rodata 166544 166544 0 0.0
.text 1139344 1139344 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1206971 1206971 0 0.0
.bss 11217 11217 0 0.0
.data 3688 3688 0 0.0
.rodata 108336 108336 0 0.0
.text 976846 976846 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1217783 1217783 0 0.0
.bss 11393 11393 0 0.0
.data 3664 3664 0 0.0
.rodata 107276 107276 0 0.0
.text 988600 988600 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1298707 1298707 0 0.0
.bss 19701 19701 0 0.0
.data 4224 4224 0 0.0
.rodata 123708 123708 0 0.0
.text 1051810 1051810 0 0.0
bl706-eth (read/write) 1024405 1024405 0 0.0
.bss 23792 23792 0 0.0
.data 3264 3264 0 0.0
.rodata 101660 101660 0 0.0
.text 767702 767702 0 0.0
bl706-wifi (read/write) 1259078 1259078 0 0.0
.bss 10677 10677 0 0.0
.data 3696 3696 0 0.0
.rodata 122660 122660 0 0.0
.text 999606 999606 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1176312 1176312 0 0.0
.bss 16428 16428 0 0.0
.data 5048 5048 0 0.0
.rodata 102340 102340 0 0.0
.text 969712 969712 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1187720 1187720 0 0.0
.bss 16604 16604 0 0.0
.data 5032 5032 0 0.0
.rodata 101280 101280 0 0.0
.text 982034 982034 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 782020 782020 0 0.0
(read/write) 168824 168824 0 0.0
.bss 90780 90780 0 0.0
.data 3584 3584 0 0.0
.rodata 82532 82532 0 0.0
.text 699220 699220 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 798188 798188 0 0.0
(read/write) 178976 178976 0 0.0
.bss 100948 100948 0 0.0
.data 3576 3576 0 0.0
.rodata 76684 76684 0 0.0
.text 721236 721236 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 786828 786828 0 0.0
(read/write) 173416 173416 0 0.0
.bss 95388 95388 0 0.0
.data 3576 3576 0 0.0
.rodata 103436 103436 0 0.0
.text 683124 683124 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 739124 739124 0 0.0
(read/write) 167784 167784 0 0.0
.bss 89520 89520 0 0.0
.data 3568 3568 0 0.0
.rodata 78196 78196 0 0.0
.text 660660 660660 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 724764 724764 0 0.0
(read/write) 168000 168000 0 0.0
.bss 89736 89736 0 0.0
.data 3568 3568 0 0.0
.rodata 73972 73972 0 0.0
.text 650524 650524 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586210 586210 0 0.0
(read/write) 208080 208080 0 0.0
.bss 201308 201308 0 0.0
.data 1648 1648 0 0.0
.rodata 87418 87418 0 0.0
.text 496668 496668 0 0.0
lock CC3235SF_LAUNCHXL (read only) 631018 631018 0 0.0
(read/write) 208336 208336 0 0.0
.bss 201712 201712 0 0.0
.data 1504 1504 0 0.0
.rodata 107762 107762 0 0.0
.text 521132 521132 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 569295 569295 0 0.0
.app_xip_area 459213 459213 0 0.0
.bss 64908 64908 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 551551 551551 0 0.0
.app_xip_area 436797 436797 0 0.0
.bss 69572 69572 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 572391 572391 0 0.0
.app_xip_area 463813 463813 0 0.0
.bss 63444 63444 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 564591 564591 0 0.0
.app_xip_area 452821 452821 0 0.0
.bss 66556 66556 0 0.0
.data 792 792 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1113520 1113520 0 0.0
.bss 195272 195272 0 0.0
.data 3432 3432 0 0.0
.text 914796 914796 0 0.0
window-app BRD4187C (read/write) 1160736 1160736 0 0.0
.bss 167600 167600 0 0.0
.data 3336 3336 0 0.0
.text 989780 989780 0 0.0
lock-app BRD4338a (read/write) 959936 959928 -8 -0.0
.bss 210204 210204 0 0.0
.data 30192 30192 0 0.0
.text 700172 700164 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1213316 1213316 0 0.0
(read/write) 1750240 1750240 0 0.0
.dram0.bss 74384 74384 0 0.0
.dram0.data 13628 13628 0 0.0
.flash.rodata 252704 252704 0 0.0
.flash.text 1213316 1213316 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1255131 1255131 0 0.0
(read/write) 536396 536396 0 0.0
.dram0.bss 81064 81064 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 284232 284232 0 0.0
.flash.text 1248967 1248967 0 0.0
.iram0.text 125403 125403 0 0.0
linux chip-tool-ipv6only arm64 (read only) 11400932 11400932 0 0.0
(read/write) 590320 590320 0 0.0
.bss 103736 103736 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 455952 455952 0 0.0
.dynamic 512 512 0 0.0
.got 17112 17112 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 355860 355860 0 0.0
.text 10163336 10163336 0 0.0
thermostat-no-ble arm64 (read only) 4426556 4426556 0 0.0
(read/write) 244720 244720 0 0.0
.bss 121976 121976 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 104312 104312 0 0.0
.dynamic 512 512 0 0.0
.got 8712 8712 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 159988 159988 0 0.0
.text 3929976 3929976 0 0.0
air-purifier-app debug (read only) 2643693 2643693 0 0.0
(read/write) 130032 130032 0 0.0
.bss 46736 46736 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184208 184208 0 0.0
.text 2280469 2280469 0 0.0
all-clusters-app debug (read only) 5952185 5952185 0 0.0
(read/write) 481536 481536 0 0.0
.bss 135072 135072 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334472 334472 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1432 1432 0 0.0
.rodata 349744 349744 0 0.0
.text 5167635 5167635 0 0.0
all-clusters-minimal-app debug (read only) 5232433 5232433 0 0.0
(read/write) 237488 237488 0 0.0
.bss 127904 127904 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98056 98056 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 288714 288714 0 0.0
.text 4707571 4707571 0 0.0
bridge-app debug (read only) 4625897 4625897 0 0.0
(read/write) 218336 218336 0 0.0
.bss 118400 118400 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 86976 86976 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 229546 229546 0 0.0
.text 4174627 4174627 0 0.0
chip-tool debug (read only) 12080841 12080841 0 0.0
(read/write) 523032 523032 0 0.0
.bss 94680 94680 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416000 416000 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 450585 450585 0 0.0
.text 10921875 10921875 0 0.0
lock-app debug (read only) 4690865 4690865 0 0.0
(read/write) 205552 205552 0 0.0
.bss 113696 113696 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 81016 81016 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 255242 255242 0 0.0
.text 4222963 4222963 0 0.0
ota-provider-app debug (read only) 4307129 4307129 0 0.0
(read/write) 194224 194224 0 0.0
.bss 113472 113472 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70448 70448 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 208458 208458 0 0.0
.text 3904163 3904163 0 0.0
ota-requestor-app debug (read only) 4436793 4436793 0 0.0
(read/write) 198592 198592 0 0.0
.bss 114368 114368 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73552 73552 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 214698 214698 0 0.0
.text 4023043 4023043 0 0.0
shell debug (read only) 2918161 2918161 0 0.0
(read/write) 156936 156936 0 0.0
.bss 62544 62544 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87168 87168 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1104 1104 0 0.0
.rodata 185568 185568 0 0.0
.text 2557890 2557890 0 0.0
tv-app debug (read only) 5761249 5761249 0 0.0
(read/write) 353200 353200 0 0.0
.bss 244240 244240 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95128 95128 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 292522 292522 0 0.0
.text 5225475 5225475 0 0.0
tv-casting-app debug (read only) 9890993 9890993 0 0.0
(read/write) 340784 340784 0 0.0
.bss 156080 156080 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174816 174816 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1208 1208 0 0.0
.rodata 382904 382904 0 0.0
.text 9041379 9041379 0 0.0
lighting-app debug+rpc+ui (read only) 5548793 5548793 0 0.0
(read/write) 227096 227096 0 0.0
.bss 119336 119336 0 0.0
.data 4864 4864 0 0.0
.data.rel.ro 95376 95376 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 353396 353396 0 0.0
.text 4947283 4947283 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2534344 2534344 0 0.0
.bss 220472 220472 0 0.0
.data 5216 5216 0 0.0
.text 1497028 1497028 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1064320 1064320 0 0.0
bss 133107 133107 0 0.0
rodata 102960 102960 0 0.0
text 781028 781028 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1011800 1011800 0 0.0
bss 131965 131965 0 0.0
rodata 90224 90224 0 0.0
text 742396 742396 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1225420 1225420 0 0.0
bss 127163 127163 0 0.0
rodata 151304 151304 0 0.0
text 796928 796928 0 0.0
nxp contact k32w0+release (read only) 574540 574540 0 0.0
(read/write) 79988 79988 0 0.0
.bss 67824 67824 0 0.0
.data 2180 2180 0 0.0
.text 574004 574004 0 0.0
light k32w0+release (read only) 608552 608552 0 0.0
(read/write) 79464 79464 0 0.0
.bss 67280 67280 0 0.0
.data 2200 2200 0 0.0
.text 608016 608016 0 0.0
contact k32w1+release (read only) 1024 1024 0 0.0
(read/write) 701492 701492 0 0.0
.bss 71176 71176 0 0.0
.data 2856 2856 0 0.0
.text 588080 588080 0 0.0
light k32w1+release (read only) 1024 1024 0 0.0
(read/write) 793384 793384 0 0.0
.bss 80728 80728 0 0.0
.data 2056 2056 0 0.0
.text 671232 671232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832280 832280 0 0.0
(read/write) 1802628 1802628 0 0.0
.bss 198372 198372 0 0.0
.data 2688 2688 0 0.0
.text 1593180 1593180 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835432 835432 0 0.0
(read/write) 1724516 1724516 0 0.0
.bss 195252 195252 0 0.0
.data 2656 2656 0 0.0
.text 1518220 1518220 0 0.0
light cy8ckit_062s2_43012 (read only) 842160 842160 0 0.0
(read/write) 1643252 1643252 0 0.0
.bss 188716 188716 0 0.0
.data 2464 2464 0 0.0
.text 1443684 1443684 0 0.0
lock cy8ckit_062s2_43012 (read only) 815096 815096 0 0.0
(read/write) 1672036 1672036 0 0.0
.bss 215788 215788 0 0.0
.data 2456 2456 0 0.0
.text 1445404 1445404 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1131760 1131760 0 0.0
.bss 102572 102572 0 0.0
.data 844 844 0 0.0
.text 644144 644144 0 0.0
lock-app qpg6105+debug (read/write) 1091576 1091576 0 0.0
.bss 97236 97236 0 0.0
.data 856 856 0 0.0
.text 603956 603956 0 0.0
stm32 light STM32WB5MM-DK (read/write) 603221 603221 0 0.0
.bss 128436 128436 0 0.0
.data 676 676 0 0.0
.rodata 80108 80108 0 0.0
.text 384256 384256 0 0.0
telink window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 842584 842584 0 0.0
bss 68008 68008 0 0.0
text 633060 633060 0 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 836982 836982 0 0.0
bss 49968 49968 0 0.0
text 628556 628556 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1095732 1095732 0 0.0
bss 101520 101520 0 0.0
text 797174 797174 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 912684 912684 0 0.0
bss 92724 92724 0 0.0
text 654974 654974 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1089092 1089092 0 0.0
bss 99816 99816 0 0.0
text 792984 792984 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 932376 932376 0 0.0
bss 92428 92428 0 0.0
text 674546 674546 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 798068 798068 0 0.0
bss 56036 56036 0 0.0
text 597546 597546 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 675700 675700 0 0.0
bss 73412 73412 0 0.0
text 461536 461536 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 857733 857733 0 0.0
bss 59660 59660 0 0.0
text 641596 641596 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 823560 823560 0 0.0
bss 56368 56368 0 0.0
text 617038 617038 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1057196 1057196 0 0.0
bss 109968 109968 0 0.0
text 771536 771536 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 934948 934948 0 0.0
bss 77476 77476 0 0.0
text 702106 702106 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 909524 909524 0 0.0
bss 69144 69144 0 0.0
text 659068 659068 0 0.0
air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 832266 832266 0 0.0
bss 49820 49820 0 0.0
text 623442 623442 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834238 834238 0 0.0
bss 49864 49864 0 0.0
text 625488 625488 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 841978 841978 0 0.0
bss 51500 51500 0 0.0
text 632030 632030 0 0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller review - pending
3 participants
@achaulk-goog @andy31415 @yufengwangca