Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESP32] Support Thread and Wi-Fi network revert configuration #33745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DejinChen
Copy link
Contributor

Problem

Platform ESP32 do not support Wi-Fi reverting network nor Thread reverting network to disconnect state.

Change overview

  • Removed check for KVS value point to support Thread reverting network to disconnect state
  • Added RevertConfiguration for Wi-Fi

Testing

RevertConfiguration for Wi-Fi and Thread network on ESP32-C6.

Copy link

github-actions bot commented Jun 5, 2024

PR #33745: Size comparison from 0050994 to 3d962c8

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 0050994 3d962c8 change % change
bl602 lighting-app bl602 FLASH 1267960 1267960 0 0.0
RAM 95408 95408 0 0.0
bl602+mfd FLASH 1282238 1282238 0 0.0
RAM 95560 95560 0 0.0
bl602+rpc FLASH 1307174 1307174 0 0.0
RAM 103840 103840 0 0.0
bl702 lighting-app bl702 FLASH 1088666 1088666 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099360 1099360 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1178490 1178490 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 872000 872000 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1123626 1123626 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1075552 1075552 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1086814 1086814 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797492 797492 0 0.0
RAM 103216 103216 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813184 813184 0 0.0
RAM 113696 113696 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802564 802564 0 0.0
RAM 107816 107816 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755476 755476 0 0.0
RAM 101924 101924 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741132 741132 0 0.0
RAM 102164 102164 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 604350 604350 0 0.0
RAM 204592 204592 0 0.0
lock CC3235SF_LAUNCHXL FLASH 649626 649626 0 0.0
RAM 204852 204852 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661053 661053 0 0.0
RAM 74592 74592 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 680897 680897 0 0.0
RAM 77224 77224 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 680897 680897 0 0.0
RAM 77224 77224 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 637841 637841 0 0.0
RAM 69660 69660 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603533 603533 0 0.0
RAM 70296 70296 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623177 623177 0 0.0
RAM 72848 72848 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623177 623177 0 0.0
RAM 72848 72848 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618885 618885 0 0.0
RAM 73312 73312 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638601 638601 0 0.0
RAM 75864 75864 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638601 638601 0 0.0
RAM 75864 75864 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587653 587653 0 0.0
RAM 67280 67280 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607505 607505 0 0.0
RAM 69912 69912 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607505 607505 0 0.0
RAM 69912 69912 0 0.0
efr32 lighting-app BRD4187C FLASH 887672 887672 0 0.0
RAM 183504 183504 0 0.0
lock-app BRD4338a FLASH 700520 700512 -8 -0.0
RAM 242708 242708 0 0.0
window-app BRD4187C FLASH 967876 967876 0 0.0
RAM 167936 167936 0 0.0
esp32 all-clusters-app c3devkit DRAM 88404 88308 -96 -0.1
FLASH 1465246 1465226 -20 -0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114876 114780 -96 -0.1
FLASH 1533955 1533975 20 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4576 4576 0 0.0
FLASH 2529872 2529872 0 0.0
RAM 128832 128832 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5561342 5561342 0 0.0
RAM 481944 481944 0 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5047448 5047448 0 0.0
RAM 236520 236520 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4475576 4475576 0 0.0
RAM 216544 216544 0 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11514295 11514295 0 0.0
RAM 521474 521474 0 0.0
chip-tool-ipv6only arm64 unknown 17368 17368 0 0.0
FLASH 10663460 10663460 0 0.0
RAM 569472 569472 0 0.0
fabric-admin debug unknown 5592 5592 0 0.0
FLASH 11276887 11276887 0 0.0
RAM 514786 514786 0 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4345384 4345384 0 0.0
RAM 208592 208592 0 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5361826 5361826 0 0.0
RAM 225136 225136 0 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4539512 4539512 0 0.0
RAM 203968 203968 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4175544 4175544 0 0.0
RAM 192928 192928 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4299640 4299640 0 0.0
RAM 197440 197440 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2794637 2794637 0 0.0
RAM 154168 154168 0 0.0
thermostat-no-ble arm64 unknown 9144 9144 0 0.0
FLASH 4148500 4148500 0 0.0
RAM 234344 234344 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5585240 5585240 0 0.0
RAM 344600 344600 0 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9565254 9565254 0 0.0
RAM 340016 340016 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497156 1497156 0 0.0
RAM 226152 226152 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 872776 872776 0 0.0
RAM 139209 139209 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 948124 948124 0 0.0
RAM 137637 137637 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 821680 821680 0 0.0
RAM 138107 138107 0 0.0
nxp contact k32w0+release FLASH 575492 575492 0 0.0
RAM 70112 70112 0 0.0
k32w1+release FLASH 590888 590888 0 0.0
RAM 74144 74144 0 0.0
light k32w0+release FLASH 609408 609408 0 0.0
RAM 69588 69588 0 0.0
k32w1+release FLASH 673728 673728 0 0.0
RAM 82896 82896 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1608916 1608916 0 0.0
RAM 207212 207212 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1533492 1533492 0 0.0
RAM 204116 204116 0 0.0
light cy8ckit_062s2_43012 FLASH 1459868 1459868 0 0.0
RAM 197396 197396 0 0.0
lock cy8ckit_062s2_43012 FLASH 1461996 1461996 0 0.0
RAM 224460 224460 0 0.0
qpg lighting-app qpg6105+debug FLASH 650176 650176 0 0.0
RAM 104644 104644 0 0.0
lock-app qpg6105+debug FLASH 610020 610020 0 0.0
RAM 99320 99320 0 0.0
stm32 light STM32WB5MM-DK FLASH 471484 471484 0 0.0
RAM 141732 141732 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 624960 624960 0 0.0
RAM 49944 49944 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 596982 596982 0 0.0
RAM 125184 125184 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 769686 769686 0 0.0
RAM 110132 110132 0 0.0
bridge-app tlsr9518adk80d FLASH 656458 656458 0 0.0
RAM 92888 92888 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 626766 626766 0 0.0
RAM 49988 49988 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 713698 713698 0 0.0
RAM 76580 76580 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 555272 555272 0 0.0
RAM 121432 121432 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 793042 793042 0 0.0
RAM 99980 99980 0 0.0
lock-app-dfu tlsr9528a FLASH 659810 659810 0 0.0
RAM 69268 69268 0 0.0
ota-requestor-app tlsr9518adk80d FLASH 675340 675340 0 0.0
RAM 92620 92620 0 0.0
pump-app tlsr9258a FLASH 621398 621398 0 0.0
RAM 58232 58232 0 0.0
pump-controller-app tlsr9118bdk40d FLASH 450174 450174 0 0.0
RAM 76672 76672 0 0.0
shell tlsr9518adk80d FLASH 462642 462642 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633166 633166 0 0.0
RAM 51616 51616 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642876 642876 0 0.0
RAM 59804 59804 0 0.0
thermostat tlsr9518adk80d FLASH 618224 618224 0 0.0
RAM 56492 56492 0 0.0
window-covering tlsr9258a FLASH 623168 623168 0 0.0
RAM 58448 58448 0 0.0
tizen all-clusters-app arm unknown 1556 1556 0 0.0
FLASH 1609836 1609836 0 0.0
RAM 45460 45460 0 0.0
chip-tool-ubsan arm unknown 2364 2364 0 0.0
FLASH 15626350 15626350 0 0.0
RAM 6822000 6822000 0 0.0
@DejinChen DejinChen force-pushed the esp32/support_network_revert_configuration branch from 3d962c8 to 4569dc9 Compare June 12, 2024 03:47
Copy link

github-actions bot commented Jun 12, 2024

PR #33745: Size comparison from bfa3e6f to 4569dc9

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section bfa3e6f 4569dc9 change % change
bl602 lighting-app bl602 FLASH 1268298 1268298 0 0.0
RAM 95424 95424 0 0.0
bl602+mfd FLASH 1282576 1282576 0 0.0
RAM 95576 95576 0 0.0
bl602+rpc FLASH 1307256 1307256 0 0.0
RAM 103856 103856 0 0.0
bl702 lighting-app bl702 FLASH 1088938 1088938 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099888 1099888 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1179018 1179018 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 872114 872114 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1124146 1124146 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1076080 1076080 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1087342 1087342 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797596 797596 0 0.0
RAM 103184 103184 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813392 813392 0 0.0
RAM 113664 113664 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802756 802756 0 0.0
RAM 107784 107784 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755244 755244 0 0.0
RAM 101884 101884 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 740900 740900 0 0.0
RAM 102132 102132 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 604846 604846 0 0.0
RAM 204608 204608 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650634 650634 0 0.0
RAM 204868 204868 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661253 661253 0 0.0
RAM 74608 74608 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681105 681105 0 0.0
RAM 77240 77240 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681105 681105 0 0.0
RAM 77240 77240 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638033 638033 0 0.0
RAM 69676 69676 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603429 603429 0 0.0
RAM 70312 70312 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623073 623073 0 0.0
RAM 72864 72864 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623073 623073 0 0.0
RAM 72864 72864 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619221 619221 0 0.0
RAM 73328 73328 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638945 638945 0 0.0
RAM 75880 75880 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638945 638945 0 0.0
RAM 75880 75880 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587469 587469 0 0.0
RAM 67296 67296 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607313 607313 0 0.0
RAM 69928 69928 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607313 607313 0 0.0
RAM 69928 69928 0 0.0
efr32 lighting-app BRD4187C FLASH 887832 887832 0 0.0
RAM 183520 183520 0 0.0
lock-app BRD4338a FLASH 701672 701664 -8 -0.0
RAM 242804 242804 0 0.0
window-app BRD4187C FLASH 968748 968740 -8 -0.0
RAM 167952 167952 0 0.0
esp32 all-clusters-app c3devkit DRAM 88420 88324 -96 -0.1
FLASH 1466214 1466436 222 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114892 114796 -96 -0.1
FLASH 1535419 1535635 216 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4576 4576 0 0.0
FLASH 2532240 2532240 0 0.0
RAM 129104 129104 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5568590 5568590 0 0.0
RAM 482296 482296 0 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5052616 5052616 0 0.0
RAM 236888 236888 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4477768 4477768 0 0.0
RAM 216816 216816 0 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11489463 11489463 0 0.0
RAM 533474 533474 0 0.0
chip-tool-ipv6only arm64 unknown 19728 19728 0 0.0
FLASH 10632852 10632852 0 0.0
RAM 581464 581464 0 0.0
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 11259575 11259575 0 0.0
RAM 527058 527058 0 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4347352 4347352 0 0.0
RAM 208864 208864 0 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5366002 5366002 0 0.0
RAM 225424 225424 0 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4543272 4543272 0 0.0
RAM 204240 204240 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4177528 4177528 0 0.0
RAM 193200 193200 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4301976 4301976 0 0.0
RAM 197840 197840 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2799949 2799949 0 0.0
RAM 154424 154424 0 0.0
thermostat-no-ble arm64 unknown 9160 9160 0 0.0
FLASH 4149604 4149604 0 0.0
RAM 234616 234616 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5586952 5586952 0 0.0
RAM 345672 345672 0 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9537926 9537926 0 0.0
RAM 351968 351968 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497748 1497748 0 0.0
RAM 226168 226168 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 873828 873828 0 0.0
RAM 139225 139225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 948512 948512 0 0.0
RAM 137653 137653 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 821804 821804 0 0.0
RAM 138123 138123 0 0.0
nxp contact k32w0+release FLASH 575220 575220 0 0.0
RAM 70120 70120 0 0.0
k32w1+release FLASH 590464 590464 0 0.0
RAM 74152 74152 0 0.0
light k32w0+release FLASH 609216 609216 0 0.0
RAM 69596 69596 0 0.0
k32w1+release FLASH 673648 673648 0 0.0
RAM 82904 82904 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1610156 1610156 0 0.0
RAM 207228 207228 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534356 1534356 0 0.0
RAM 204132 204132 0 0.0
light cy8ckit_062s2_43012 FLASH 1460652 1460652 0 0.0
RAM 197412 197412 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462948 1462948 0 0.0
RAM 224476 224476 0 0.0
qpg lighting-app qpg6105+debug FLASH 650216 650216 0 0.0
RAM 104652 104652 0 0.0
lock-app qpg6105+debug FLASH 610196 610196 0 0.0
RAM 99328 99328 0 0.0
stm32 light STM32WB5MM-DK FLASH 472124 472124 0 0.0
RAM 141748 141748 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625098 625098 0 0.0
RAM 49952 49952 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 600692 600692 0 0.0
RAM 130384 130384 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770308 770308 0 0.0
RAM 110148 110148 0 0.0
bridge-app tlsr9258a FLASH 668228 668228 0 0.0
RAM 94768 94768 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 626850 626850 0 0.0
RAM 49996 49996 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 712688 712688 0 0.0
RAM 76588 76588 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 557830 557830 0 0.0
RAM 126640 126640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 792896 792896 0 0.0
RAM 99996 99996 0 0.0
lock-app-dfu tlsr9528a FLASH 660154 660154 0 0.0
RAM 69276 69276 0 0.0
ota-requestor-app tlsr9258a FLASH 686564 686564 0 0.0
RAM 94492 94492 0 0.0
pump-app tlsr9518adk80d FLASH 609050 609050 0 0.0
RAM 56376 56376 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599398 599398 0 0.0
RAM 56176 56176 0 0.0
shell tlsr9518adk80d FLASH 462618 462618 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633244 633244 0 0.0
RAM 51624 51624 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642236 642236 0 0.0
RAM 59812 59812 0 0.0
thermostat tlsr9518adk80d FLASH 618300 618300 0 0.0
RAM 56500 56500 0 0.0
window-covering tlsr9118bdk40d FLASH 464616 464616 0 0.0
RAM 82272 82272 0 0.0
tizen all-clusters-app arm unknown 1552 1552 0 0.0
FLASH 1613128 1613128 0 0.0
RAM 45460 45460 0 0.0
chip-tool-ubsan arm unknown 2360 2360 0 0.0
FLASH 15705266 15705266 0 0.0
RAM 6889008 6889008 0 0.0
@pullapprove pullapprove bot requested a review from ReneJosefsen June 26, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment