Proposed changes to split tests into separate binaries for efr32 [Version 1] #33786
+185
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to use glob, and updated the test runner to use the flash_image parameter for directories
|
PR #33786: Size comparison from 72450e4 to 53f4263 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
feasel0
commented
Jun 6, 2024
| copy(flashing_runtime_target) { | ||
| sources = flashing_script_inputs | ||
| outputs = [ "${root_out_dir}/{{source_file_part}}" ] | ||
| if (defined(invoker.copy_py_files) && invoker.copy_py_files) { #++++ added this |
There was a problem hiding this comment.
The "copy" action only needs to be done once per build, however now that silabs_executable is being called many times it ends up trying to copy these same python files repeatedly which causes an error. I could not find a clean way of making it only copy once, so as a workaround I use a variable copy_py_files that controls whether the files get copied or not. This variable is set to false after silabs_executable is invoked so the files won't be copied next time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach here is to keep the
silabs_executabletargets insidesrc/test_driver/efr32/BUILD.gnand to leavechip_test_suitealone without any knowledge of efr32.This creates a
.s37file for each test suite. I have tested the build process and it seems to generate the correct files, with each.s37file only having the tests for that particular suite. However without the hardware I have not yet flashed and run them on a device, so I can only judge by the.mapfile what's inside them. But in general I believe this PR is functional and does what it's supposed to do.Note that even though there's a binary for each test directory (rather than a binary for each individual test source within that directory), each of the binaries is able to build without a complaint about flash size limitations. So that means so far none of our test directories are too large to fit on the device. So we could get away with 20-something binaries instead of 200-something if we wanted to go this route.
(This is a work in progress, so please ignore any commented-out code and print statements.)
The drawback to this approach is that it requires
src/test_driver/efr32/BUILD.gnto have a list of all test directories. This is not ideal since it will need to be updated any time a new test directory is created. To avoid this I have made another version which moves thesilabs_executabletarget intochip_test_suite. See Version 2.