[Silabs] Adds fix for Wi-Fi task loop, BLE task priority, BLE indication soft timer expiry #34095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
…eadability and maintainability" This reverts commit 9f1b180.
|
PR #34095: Size comparison from f199ba4 to d55fcc0 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34095: Size comparison from f199ba4 to 3c861d4 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Jul 9, 2024
lazarkov
pushed a commit
to lazarkov/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…ion soft timer expiry (project-chip#34095) * Adds fix for WiFi task looping * Adds fix for BLE task priority and indication soft timer expiry * Adds fix for return check * Remove unused cred and add length check * aligned include * Replace `lx` with `x` for all sl_status_t logging * Refactor posting of events to the end of the codeblock * Adds `BLE_DRIVER_TASK_PRIORITY` * Adds static_cast for status in ChipLogging * chore: Refactor show_scan_results function to improve readability and maintainability * chore: Update WiFi join function to use strnlen for SSID length calculation * chore: Update WiFi join function to use strnlen for SSID length calculation * chore: Update BSSID array size in WiFi scan result struct * chore: Update SLAAC OK log message to use formatted IPv6 address * Refactor show_scan_results function for improved readability and maintainability * Refactor show_scan_results function to fix null termination bug * Refactor show_scan_results function to fix null termination bug * Adds fix for NCP macros * Revert BLE timer changes * Fix passkey length validation in sl_wifi_if.cpp * Refactor BLEManagerImpl::_OnPlatformEvent for improved code readability and maintainability * Refactor BLEManagerImpl::_OnPlatformEvent for improved code readability and maintainability * Revert "Refactor BLEManagerImpl::_OnPlatformEvent for improved code readability and maintainability" This reverts commit 9f1b180. * Added locks to avoid race conditions * Addressed comments * Refactor sl_wifi_if.cpp for improved code readability and maintainability * Fix passkey length validation in sl_wifi_if.cpp * Fix BSSID length in wfx_rsi_get_ap_info and wfx_rsi_save_ap_info * Refactor log statement after length checks * Adds missing replace --------- Co-authored-by: brosahay <3526930+brosahay@users.noreply.github.com>
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…ion soft timer expiry (project-chip#34095) * Adds fix for WiFi task looping * Adds fix for BLE task priority and indication soft timer expiry * Adds fix for return check * Remove unused cred and add length check * aligned include * Replace `lx` with `x` for all sl_status_t logging * Refactor posting of events to the end of the codeblock * Adds `BLE_DRIVER_TASK_PRIORITY` * Adds static_cast for status in ChipLogging * chore: Refactor show_scan_results function to improve readability and maintainability * chore: Update WiFi join function to use strnlen for SSID length calculation * chore: Update WiFi join function to use strnlen for SSID length calculation * chore: Update BSSID array size in WiFi scan result struct * chore: Update SLAAC OK log message to use formatted IPv6 address * Refactor show_scan_results function for improved readability and maintainability * Refactor show_scan_results function to fix null termination bug * Refactor show_scan_results function to fix null termination bug * Adds fix for NCP macros * Revert BLE timer changes * Fix passkey length validation in sl_wifi_if.cpp * Refactor BLEManagerImpl::_OnPlatformEvent for improved code readability and maintainability * Refactor BLEManagerImpl::_OnPlatformEvent for improved code readability and maintainability * Revert "Refactor BLEManagerImpl::_OnPlatformEvent for improved code readability and maintainability" This reverts commit 9f1b180. * Added locks to avoid race conditions * Addressed comments * Refactor sl_wifi_if.cpp for improved code readability and maintainability * Fix passkey length validation in sl_wifi_if.cpp * Fix BSSID length in wfx_rsi_get_ap_info and wfx_rsi_save_ap_info * Refactor log statement after length checks * Adds missing replace --------- Co-authored-by: brosahay <3526930+brosahay@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem/Feature:
osYeildwithout a blocking call, causing lower priority task to be starved by the scheduler.CHIPOBLE_PROTOCOL_ABORTerror.Description of Fix/Solution:
SILABS_LOGSandVerifyOrReturnError