[DRLK] Add fabric restrictions to SetWeekDaySchedule and SetYearDaySchedule #34138
+211
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commands to
allow schedules to be added/modified only by the fabric that created
the corresponding user.
Update YAML schedule test to verify behavior
Accompanies DRLK spec change:
CHIP-Specifications/connectedhomeip-spec#10005
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
bzbarsky-apple
approved these changes
Jul 18, 2024
Comment on lines
+1916
to
+1917
| void DoorLockServer::updateLastModifiedFabricIndexOfUser(chip::EndpointId endpointId, uint16_t userIndex, | ||
| EmberAfPluginDoorLockUserInfo & userInfo, chip::FabricIndex fabricIndex) |
There was a problem hiding this comment.
Suggested change
| void DoorLockServer::updateLastModifiedFabricIndexOfUser(chip::EndpointId endpointId, uint16_t userIndex, | |
| EmberAfPluginDoorLockUserInfo & userInfo, chip::FabricIndex fabricIndex) | |
| void DoorLockServer::updateLastModifiedFabricIndexOfUser(EndpointId endpointId, uint16_t userIndex, | |
| EmberAfPluginDoorLockUserInfo & userInfo, FabricIndex fabricIndex) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fabric restrictions to SetWeekDaySchedule and SetYearDaySchedule commands to
allow schedules to be added/modified only by the fabric that created the corresponding user.
Update YAML schedule test to verify behavior
Accompanies DRLK spec change: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10005