Update ACL after content app is installed #34229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
lazarkov
force-pushed
the
feature/refresh-content-app-acl
branch
from
0ae9d3c
to
55f4288
Compare
|
PR #34229: Size comparison from f83d67b to 55f4288 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Jul 11, 2024
|
PR #34229: Size comparison from c70a769 to e188180 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34229: Size comparison from c70a769 to e8a4ada Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 18, 2024
* Add code to update ACL after app is installed * Restyled by whitespace * Restyled by clang-format * Update code per comments * Restyled by whitespace * Restyled by clang-format * Minor code updates * Restyled by clang-format * Update description * Update logic to support extern DeviceCommissioner & CommissionerDiscoveryController * Restyled by clang-format * Test the change to see if it will fix the tests * Update AppTv.cpp * Update code as it failed tests * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the PR #34141
It also covers certain part of the issue #34203
Problem
After app is installed the ACL is obsolete and sending commands to the app will fail
Change overview
-- New methods are able to store node id for after each commissioning
Tests - TV Android App - App Install and send Media Playback Command
Build the Android TV app using command:
scripts/examples/gn_build_example.sh examples/tv-app/linux out/debug/Build the TV casting app using command:
scripts/examples/gn_build_example.sh examples/tv-casting-app/linux out/debug/Start TV Android App
Start TV Casting App
out/debug/chip-tv-casting-appSend Media Playback command
cast cluster mediaplayback play 0 5You should get an error
Install content app using
adb install -r -t content-app-debug.apkSend Media Playback command again
cast cluster mediaplayback play 0 5You should receive pending state:
{ status: 0, data: custom response from content app for media playback }Tests - TV Linux App - App Install and send Media Playback Command
Build the TV app using command:
scripts/examples/gn_build_example.sh examples/tv-app/linux out/debug/Build the TV casting app using command:
scripts/examples/gn_build_example.sh examples/tv-casting-app/linux out/debug/Start TV App
out/debug/chip-tv-appStart TV Casting App
out/debug/chip-tv-casting-appOn TV App: Uninstall the app
app uninstall 65521 32769On TV Casting App: Send casting request to the tv-app using
cast request 0On TV App: Accepted the Cast request from the tv-casting app
controller ux okOn TV App: Enter the PIN code (passcode)
controller ux ok 20202021On TV Casting App: Send Media Playback command to the tv-app using
cast cluster mediaplayback play 0 8It should fail
On TV App: Install the app
app install 65521 32769On TV Casting App: Send Media Playback command to the tv-app using
cast cluster mediaplayback play 0 8