DSN migration for pydantic v3 #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
Please review |
|
Hello there! All checks for Python 3.8 have failed :( Seems like Python 3.8 doesn't have Annotated class |
|
I also think it would make sense to move the entire |
yezz123
reviewed
May 13, 2024
yezz123
approved these changes
May 13, 2024
There was a problem hiding this comment.
Waiting for @sydney-runkle approval and then we can merge it, Overall LGTM 🚀
|
@yezz123 @sydney-runkle can we move other stuff from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to this task from Pydantic main library.
I moved DSN types and tests from original
pydantic/networks.pywithout any changesChecklist
✅ The pull request title is a good summary of the changes - it will be used in the changelog
✅ Unit tests for the changes exist
Selected Reviewer: @yezz123