Skip to content
This repository has been archived by the owner on Jul 6, 2021. It is now read-only.

Document QUnit.jsDump.parse #29

Closed
jugglinmike opened this issue Dec 5, 2013 · 3 comments
Closed

Document QUnit.jsDump.parse #29

jugglinmike opened this issue Dec 5, 2013 · 3 comments

Comments

@jugglinmike
Copy link
Contributor

Given QUnit.jsDump.parse's utility in defining custom assertions (and the unit tests backing its behavior [1] [2] [3]), the method appears to be part of the public API. Can someone on the team confirm this?

If so, then the documentation should be extended to describe its usage.

[1] https://github.com/jquery/qunit/blob/81d499b0fb06970b5f52185b8153416341c0d49e/test/test.js#L394-L402
[2] https://github.com/jquery/qunit/blob/81d499b0fb06970b5f52185b8153416341c0d49e/test/test.js#L667-L685
[3] https://github.com/jquery/qunit/blob/81d499b0fb06970b5f52185b8153416341c0d49e/test/test.js#L702-L728

@jzaefferer
Copy link
Member

Good call. I agree that this should be documented.

@jzaefferer
Copy link
Member

@leobalter could you look into writing the docs for this?

@leobalter
Copy link
Member

\o/ sure

leobalter added a commit to leobalter/api.qunitjs.com that referenced this issue Jan 30, 2014
leobalter added a commit to leobalter/api.qunitjs.com that referenced this issue Feb 5, 2014
leobalter added a commit to leobalter/api.qunitjs.com that referenced this issue Feb 21, 2014
leobalter added a commit to leobalter/api.qunitjs.com that referenced this issue Feb 21, 2014
leobalter added a commit to leobalter/api.qunitjs.com that referenced this issue Feb 21, 2014
leobalter added a commit to leobalter/api.qunitjs.com that referenced this issue Feb 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants