Entries: Added assert.async. Deprecated start, stop, and asyncTest #82
Conversation
| </desc> | ||
| <longdesc> | ||
| <p class="warning"> | ||
| This method is <strong>deprecated</strong>. It is recommended to use <a href="/QUnit.test/"><code>QUnit.test()</code></a> in conjunction with <a href="/async/"><code>assery.async()</code></a> instead. |
There was a problem hiding this comment.
Also remove "recommended", should be "Use xxx instead"
There was a problem hiding this comment.
Updated for all 3 deprecated items.
|
Let's remove the examples. |
|
Deprecated examples have all been removed. |
| }); | ||
| QUnit.config.autostart = false; | ||
|
|
||
| require(["test/tests1.js", "test/tests2.js"], QUnit.start); |
There was a problem hiding this comment.
The existing AMD example explicitly calls QUnit.start() without any arguments. What happens when requirejs et al actually pass an argument to QUnit.start in this usage?
There was a problem hiding this comment.
Good point, it would be best to avoid that.
| <entry type="method" name="async"> | ||
| <title>async()</title> | ||
| <desc> | ||
| Request a new resolution callback for an asynchronous operation. |
There was a problem hiding this comment.
This sounds weird. It makes sense after reading it three times, but I think we can do better. Especially the "request a resolution" throws me off. Longdesc uses the same terms, so my issue applies there as well.
Maybe look at grunt async() docs for some inspiration?
There was a problem hiding this comment.
Grunt async: http://gruntjs.com/api/inside-tasks#this.async
|
Ping @JamesMGreene |
Fixes #79
Fixes #74
Fixes #73
Fixes #72
Closes #82