Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify qunitjs version #117

Closed
Krinkle opened this issue Mar 13, 2015 · 2 comments
Closed

Allow users to specify qunitjs version #117

Krinkle opened this issue Mar 13, 2015 · 2 comments

Comments

@Krinkle
Copy link
Member

Krinkle commented Mar 13, 2015

Under npm 1.x it loads qunitjs 1.10.0 which is quite old at this point.

Projects like karma-qunit specify a minimum version, thus allowing the final consumer to specify a different version in their package.json. https://github.com/karma-runner/karma-qunit/blob/v0.1.4/package.json:

  "peerDependencies": {
    "qunitjs": "^1.14.0"
  },

Under npm 2.x it interestingly refuses to load 1.10.0 alongside a newer version in some cases, resutling in the following:

npm WARN unmet dependency qunit requires qunitjs@'1.10.0' but will load qunitjs, which is version 1.17.1

.. on a project with:

  "devDependencies": {
    "karma": "0.12.31",
    "karma-qunit": "0.1.4",
    "qunit": "0.7.5",
    "qunitjs": "1.17.1"
@nikolas
Copy link
Contributor

nikolas commented Apr 10, 2015

Thanks for looking into this. This is kind of a duplicate of issue #110

@jzaefferer
Copy link
Member

Closing as duplicate of #110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants