-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lax qunitjs version from "1.10.0" to "^1.10.0" #118
Conversation
hmm why does it breaks travis? |
I can reproduce the error locally.
It seems the diff --git a/test/testrunner.js b/test/testrunner.js
index fdb3eb0..221f9f7 100644
--- a/test/testrunner.js
+++ b/test/testrunner.js
@@ -46,6 +46,9 @@ chain.add('base testrunner', function() {
failed: 2,
passed: 5
};
+ if (err) {
+ throw err;
+ }
a.equal(err, null, 'no errors');
a.ok(res.runtime > 0, 'Date was modified');
delete res.runtime;
The actual test in question: test('myAsyncMethod test', function() {
ok(true, 'myAsyncMethod started');
stop();
expect(3);
myAsyncMethod(function(data) {
equal(data, 123, 'myAsyncMethod returns right result');
equal(data, 321, 'this should trigger an error');
start();
});
}); |
The stacktrace points at: https://github.com/kof/node-qunit/blob/master/lib/child.js#L66 That |
yeah QUnit.start(); is called multiple times, maybe in the older version it wasn't an issue ... |
FYI, this behavior "tightening" arrived in Discussion: qunitjs/qunit#653 (comment) |
Which hopefully implies that the bug fix needed here will be backwards compatible. |
I ran into problems just trying to update node-qunit to QUnit v1.11.0: #110 |
Please fix this. Users are unable to use node-qunit with newer test suites because APIs introduced in the last 2 years of QUnit development (e.g. |
@Krinkle totally forgot this one, can we already update to an even newer version? |
1.20.0 was just released, but that shouldn't really matter, since the |
That said, you should definitely test with 1.20.0, since it might uncover other bugs in node-qunit. For example, calling |
@Krinkle would you like to become a collaborator in this project? |
also @jzaefferer ? |
Sure, also @leobalter, since he's the (new) QUnit project lead. |
done |
welcome in team @jzaefferer @Krinkle @leobalter |
@kof thanks. So, are you going to put some time into fixing this or other issues, or are you hoping for one of us to take over? |
@jzaefferer I would be glad to get some help on this |
Okay. I've got some things to discuss with @leobalter anyway, maybe we can also do a triage of issues here. |
Thanks @kof! |
Fixes #117