Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use qunitjs as dependency #86

Closed
piranna opened this issue Jan 27, 2014 · 2 comments
Closed

Use qunitjs as dependency #86

piranna opened this issue Jan 27, 2014 · 2 comments

Comments

@piranna
Copy link

piranna commented Jan 27, 2014

QUnit has a NPM ready and up-to-date package with the name qunitjs. node-qunit should use it as a dependency instead of having a hard-coded old version.
@kof
Copy link
Contributor

kof commented Jan 27, 2014

At the time I have updated it the last time there was a reason to copy qunit into the repository. There are some small changes have been done.
@Krinkle
Copy link
Member

Krinkle commented May 1, 2014

That hasn't been the case since we, 2 years ago, changed that copy to be a git instead (see 673f9d6). So it's save to switch to an npm dependency.

In fact, it's more stable to do so since in more recent versions of QUnit, it is no longer just one file (it requires building from multiple source files). By using npm you can use the published version as build when it was released, and it'll be in a stable location (not subject to internal changes to the repository).
Krinkle added a commit to Krinkle/node-qunit that referenced this issue May 1, 2014
@Krinkle
Use npm dependency instead of git submodule for QUnit
82ebf61 
Picked the same version we already had (we used to point to
1.10.0pre, this is the released 1.10.0, every so slightly newer
but compatible).

We should probably upgrade to a newer version at some point
(v1.10.0 is from August 2012, latest v1.14.0 from January 2014),
but one stap at a time :)

Fixes qunitjs#86
@kof kof closed this as completed in 9a087c7 May 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@kof @Krinkle @piranna