add Interpolations.jl extension #586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaqz
force-pushed
the
interpolations
branch
from
ff89cd9
to
06b5cd7
Compare
|
Closes #420 @DanDeepPhase we can implement this pretty easily now. But if you have any comments on syntax or how this should work that would help. See the new tests added here for an example. |
|
Any particular reason this was closed? |
|
In favour of Which needs tests, and I forgot about. And I'm not really sure on the best syntax. Feedback appreciated. |
* linear interpolation * Apply suggestions from code review Co-authored-by: Rafael Schouten <rafaelschouten@gmail.com> * Simpler implementation * compat * fixed typo missed = * Update ext/DimensionalDataInterpolations.jl * Update ext/DimensionalDataInterpolations.jl --------- Co-authored-by: Rafael Schouten <rafaelschouten@gmail.com>
|
Did #609 get merged here? I don't see the log |
|
It got merged to the branch yes, but the PR seems dead there's no reopen button Maybe that's just a phone app thing idk |
|
I guess the PR had to be reopened for the log to refresh... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea for adding an Interpolations.jl extension.
It turns out there isn't a clean way to extend Interpolations.jl methods like
interpolateorscalebecause really on aDimArrayyou would always want both and have the information for both already in one object.So the idea here (and what i personally need the most) is to define an interpolation method that lets you interpolate from one
AbstractDimArrayto another in a single command.We have most of the information we need to choose the interpolation method - users can specify e.g.
CubicorLinearif they really want to. ButBSpline/Griddedwe know fromRegular/Irregularetc.We may also want to provide an interpolator object that can interpolate points.
I'll probably leave this here for a while until its clearer what the best strategy is, but comments are welcome.