Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMEDATE] Fix a typo in en-US locale #7098

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[TIMEDATE] Fix a typo in en-US locale #7098

merged 1 commit into from
Jul 8, 2024

Conversation

Venca24
Copy link
Contributor

@Venca24 Venca24 commented Jul 7, 2024

Purpose

Fixes a typo in Timedate Control Panel's English strings IDS_INETTIMESUCFILL and IDS_INETTIMEWELCOME. The indefinite article is 'an' when it is before a vowel sound.

JIRA issue: none
@binarymaster binarymaster added the TRANSLATION For translation and localization PRs label Jul 7, 2024
@binarymaster binarymaster added this to New PRs in ReactOS PRs via automation Jul 7, 2024
ReactOS PRs automation moved this from New PRs to Approved by reviewers Jul 7, 2024
JoachimHenze
JoachimHenze approved these changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@JoachimHenze JoachimHenze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, although I would have preferred if we could have shortened the strings somewhere else in return, e.g. by stripping the "in order" to compensate for the size increase.
HBelusca
HBelusca reviewed Jul 7, 2024
View reviewed changes
Copy link
Contributor

@HBelusca HBelusca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone from the UK/USA please check:
@cbialorucki @DarkFire01 @Doug-Lyons
Doug-Lyons
Doug-Lyons approved these changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@Doug-Lyons Doug-Lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@binarymaster binarymaster merged commit cabeda8 into reactos:master Jul 8, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TRANSLATION For translation and localization PRs
5 participants
@Venca24 @binarymaster @HBelusca @Doug-Lyons @JoachimHenze