-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 milestone: drop supported versions #1500
Conversation
6e4950d
to
e32540c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't quite match what Sphinx 5 supports, so I don't think we should make all of these changes. I would be in favor of more aggressive tuning on what we visually test against -- mostly Python versions really, but perhaps docutils versions too.
Once our support matrix drops Sphinx 5 these will get tighter, but I think 5 usage is still high enough to warrant support. We're just at an unfortunate stage where our dependency graph and Sphinx's dependency graph is very wide still.
The new policy is: - Python >=3.6 - Sphinx >= 5 - HTML4 and HTML5 writer - docutils >= 0.14, < 0.19
By the beginning of 2024 we should support newer Sphinx versions and HTML5 only.
b625bfb
to
136b275
Compare
@agjohnson I updated this PR with the changes suggested. Let me know if you OK with this. I'd be happy to move forward and get closer to a 2.0 release 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really close. I noted a couple of minor tox tweaks for this release.
- drop support for HTML4 on 2.0 - keep `-qa` TOX environment to be able to compare feature branches - emit `logger.errors` on Python 2 and html_writer4=True - require Sphinx >= 5.0 - remove logic for old Sphinx versions
@agjohnson I updated this PR with some changes from your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Lets plan on getting a final 1.3.0 out before we merge this here, perhaps on Mon/Tues?
The new policy is:
HTML4 andHTML5 writer