Skip to content

Commit

Permalink
Relates to #397, source map generation for bundled files
Browse files Browse the repository at this point in the history
  • Loading branch information
jrburke committed Mar 6, 2013
1 parent 68bd03a commit a69f43a
Show file tree
Hide file tree
Showing 6 changed files with 71 additions and 1 deletion.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ build/tests/lib/removeCombined/baseUrl-built
build/tests/lib/requireHoist/perLayer/built
build/tests/lib/rhino-186/built
build/tests/lib/shimFakeDefine/main-built.js
build/tests/lib/sourcemap/www-built
build/tests/lib/stubModules/main-built.js
build/tests/lib/stubModules/perModule/built
build/tests/lib/transportBeforeMinify/www-built
Expand Down
2 changes: 1 addition & 1 deletion build/jslib/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -1637,7 +1637,7 @@ define(function (require) {
//Add to the source map
if (sourceMapGenerator) {
if (module._buildPath === path) {
sourceMapSrcSuffix = '.srcmap.js';
sourceMapSrcSuffix = '.src.js';
sourceMapPath = path.split('/').pop() + sourceMapSrcSuffix;
} else {
sourceMapPath = build.makeRelativeFilePath(module._buildPath, path);
Expand Down
25 changes: 25 additions & 0 deletions build/tests/builds.js
Original file line number Diff line number Diff line change
Expand Up @@ -1835,4 +1835,29 @@ define(['build', 'env!env/file'], function (build, file) {
]
);
doh.run();

//Test source map generation for a bundled file,
//see https://github.com/jrburke/r.js/issues/397
doh.register("sourcemap",
[
function sourcemap(t) {
file.deleteFile("lib/sourcemap/www-built");

build(["lib/sourcemap/build.js"]);

t.is(nol(c("lib/sourcemap/expected/main.js")),
nol(c("lib/sourcemap/www-built/js/main.js")));

t.is(nol(c("lib/sourcemap/expected/main.js.map")),
nol(c("lib/sourcemap/www-built/js/main.js.map")));

t.is(nol(c("lib/sourcemap/expected/main.js.src.js")),
nol(c("lib/sourcemap/www-built/js/main.js.src.js")));

require._buildReset();
}

]
);
doh.run();
});
26 changes: 26 additions & 0 deletions build/tests/lib/sourcemap/expected/main.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions build/tests/lib/sourcemap/expected/main.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions build/tests/lib/sourcemap/expected/main.js.src.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
/**
* A test of source maps on a concatenated, but not minified file.
*/
require(['a', 'b'], function (a, b) {
console.log('a name: ' + a.name);
console.log('b name: ' + b.name);
});

0 comments on commit a69f43a

Please sign in to comment.