-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r.js not preserve comments #41
Comments
Thanks for pointing this out. It was a bug. I updated the optimizer to preserve license comments. You can try r-edge.js if you want to confirm the fix. This fix will be part of the 1.0.2 release that I hope to do very soon this week, perhaps even tonight. |
Tonight, i will try … thks for your speedy answer =) Ariel Falduto On Nov 21, 2011, at 8:03 PM, James Burke wrote:
|
oh good, I was just wondering about this exact thing. |
Hey, could this be made into a build profile option? (on by default) With how many libs I'm using I may just want to have main.js link to a separate license text file that contains all the licenses I'm using. |
@GEDDesign: good point. I opened issue #42 to track that request and targeted it for a 1.0.3 release, but I do not have a release target for it yet. |
Cool, thanks. |
Sorry to bump this, but is there any way to remove license comments completely? I have 600 lines of license comments that I want gone. |
@gjtorikian setting preserveLicenseComments: false should work: https://github.com/jrburke/r.js/blob/master/build/example.build.js#L316 |
Hi guys,
i making some test cases and its imposible to preserve the comments from source files, in need to include my copyright info at the begining of file ...
take a look ...
note: in my foo.js file from source folder we have an comment like ...
/*! wooooot copyright ... fooo ... blaaa ... 2011 */
i doing something wrong ??!?!
thks !
The text was updated successfully, but these errors were encountered: