Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.js not preserve comments #41

Closed
outaTiME opened this issue Nov 21, 2011 · 8 comments
Closed

r.js not preserve comments #41

outaTiME opened this issue Nov 21, 2011 · 8 comments
Milestone

Comments

@outaTiME
Copy link

Hi guys,

i making some test cases and its imposible to preserve the comments from source files, in need to include my copyright info at the begining of file ...

take a look ...

  modules: [
    {
      name: "foo", // merge requirejs with foo file from src folder
      include: ["../vendor/requirejs/require", "foo"],
      create: true
    }
  ]

note: in my foo.js file from source folder we have an comment like ...

/*! wooooot copyright ... fooo ... blaaa ... 2011 */

i doing something wrong ??!?!

thks !

jrburke added a commit that referenced this issue Nov 21, 2011
@jrburke
Copy link
Member

jrburke commented Nov 21, 2011

Thanks for pointing this out. It was a bug. I updated the optimizer to preserve license comments. You can try r-edge.js if you want to confirm the fix.

This fix will be part of the 1.0.2 release that I hope to do very soon this week, perhaps even tonight.

@outaTiME
Copy link
Author

Tonight, i will try …

thks for your speedy answer =)

Ariel Falduto
afalduto@gmail.com

On Nov 21, 2011, at 8:03 PM, James Burke wrote:

Thanks for pointing this out. It was a bug. I updated the optimizer to preserver license comments. You can try r-edge.js if you want to confirm the fix.

This fix will be part of the 1.0.2 release that I hope to do very soon this week, perhaps even tonight.


Reply to this email directly or view it on GitHub:
#41 (comment)

@geddski
Copy link

geddski commented Nov 22, 2011

oh good, I was just wondering about this exact thing.

@geddski
Copy link

geddski commented Nov 22, 2011

Hey, could this be made into a build profile option? (on by default) With how many libs I'm using I may just want to have main.js link to a separate license text file that contains all the licenses I'm using.

@jrburke
Copy link
Member

jrburke commented Nov 22, 2011

@GEDDesign: good point. I opened issue #42 to track that request and targeted it for a 1.0.3 release, but I do not have a release target for it yet.

@geddski
Copy link

geddski commented Nov 22, 2011

Cool, thanks.

@gjtorikian
Copy link

Sorry to bump this, but is there any way to remove license comments completely? I have 600 lines of license comments that I want gone.

@jrburke
Copy link
Member

jrburke commented May 25, 2012

@gjtorikian setting preserveLicenseComments: false should work: https://github.com/jrburke/r.js/blob/master/build/example.build.js#L316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants