Fix issue when using redux and checkIntervalOfflineOnly #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR fixes
If using redux integration and option
checkIntervalOfflineOnly
.It will never make request to check internet connection.
HOC
withNetworkConnectivity
has internal state, in which connection status is stored.This however never gets updated. It's only set once during initialisation.
Test scenario
Open app and check if there is any network request made to
google.com
. There will be no requests made. If we turn off optioncheckIntervalOfflineOnly
, everything works fine.With my change, it will always sync internal state with external redux state.