Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom headers #275

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Support custom headers #275

merged 2 commits into from
Jun 11, 2020

Conversation

ugurakkurt
Copy link
Contributor

@ugurakkurt ugurakkurt commented May 29, 2020 •
edited by rgommezz
Loading

Fixes #274
@ugurakkurt ugurakkurt mentioned this pull request May 29, 2020
Closed
rgommezz
rgommezz reviewed Jun 5, 2020
View reviewed changes
Copy link
Owner

@rgommezz rgommezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ugurakkurt, many thanks for this PR! 🚀

Looking good, I left some small comments
README.md Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/utils/checkInternetConnection.ts Outdated Show resolved Hide resolved
src/utils/checkInternetAccess.ts Outdated Show resolved Hide resolved
src/utils/makeHttpRequest.ts Outdated Show resolved Hide resolved
src/utils/makeHttpRequest.ts Outdated Show resolved Hide resolved
src/utils/makeHttpRequest.ts Outdated Show resolved Hide resolved
test/checkInternetAccess.test.ts Outdated Show resolved Hide resolved
test/makeHttpRequest.test.ts Outdated Show resolved Hide resolved
@ugurakkurt ugurakkurt requested a review from rgommezz June 11, 2020 07:48
@ugurakkurt
Copy link
Contributor Author

ugurakkurt commented Jun 11, 2020 •
edited
Loading

Thank you for the review :) Updated the PR. @rgommezz
rgommezz
rgommezz approved these changes Jun 11, 2020
View reviewed changes
Copy link
Owner

@rgommezz rgommezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
@rgommezz
Copy link
Owner

@all-contributors please add @ugurakkurt for code and docs
@allcontributors allcontributors bot mentioned this pull request Jun 11, 2020
Merged
@allcontributors
Copy link
Contributor

@rgommezz

I've put up a pull request to add @ugurakkurt! 🎉
@rgommezz rgommezz merged commit 8ba2f95 into rgommezz:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@ugurakkurt @rgommezz