checkInternetConnectionOnStartup to check internet connection not only with NetInfo #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommezz
requested changes
May 30, 2018
| ): Promise<boolean> { | ||
| let connectionChecked: Promise<boolean>; | ||
| if (Platform.OS === 'ios') { | ||
| connectionChecked = new Promise(resolve: Function => { |
There was a problem hiding this comment.
There is a flow parsing error on the CI, could you please wrap (resolve: Function) into parenthesis?
I don't know if that's due to an old version (v0.42). Another alternative could be to upgrade flow to a most recent one.
But probably the easiest is the former
| connectionChecked = NetInfo.isConnected.fetch(); | ||
| } | ||
|
|
||
| return connectionChecked.then(isConnected: boolean => { |
rgommezz
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.