-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve constructor mapping readability #1337
base: main
Are you sure you want to change the base?
Conversation
3758ce1
to
082be91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this contribution! Since this is your first contribution I need to manually approve each GH Actions run...
Looks pretty good already 😊👍 I added my feedback, feel free to discuss. There are also a few test failures which need to be fixed.
90be032
to
2d67788
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good now, thanks for the updates 😊
There are still some test and linter failures which need to be fixed before merging.
See also linter failures, test failures.
@latonz Thanks! Sorry I've been very busy and couldn't get to fixing those, will do so this weekend when I hopefully get the time. |
Fixes #1322
It's my first time contributing to a source generator project, so feel free to let me know if I've made any obvious mistakes.
Thanks.
Checklist