Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): cache poetry in CI #14485

Merged

Conversation

SauravMaheshkar
Copy link
Contributor

This PR aims to cache the poetry packages in CI thereby enabling faster CI.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 1, 2024
@SauravMaheshkar
Copy link
Contributor Author

I think we'll have to reorganise the CI, poetry needs to be installed before the setup-python process

@logan-markewich
Copy link
Collaborator

@SauravMaheshkar doesn't poetry depend on having the python version setup/installed? Or I guess, happy to try swapping that around at least, as long as the correct python version is being used for workflows

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 9, 2024
@SauravMaheshkar
Copy link
Contributor Author

@SauravMaheshkar doesn't poetry depend on having the python version setup/installed? Or I guess, happy to try swapping that around at least, as long as the correct python version is being used for workflows

I swapped around the installation steps, instead of using a separate action to install this falls back to using pipx

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2024
@logan-markewich logan-markewich merged commit 2f547d6 into run-llama:main Jul 12, 2024
8 checks passed
@SauravMaheshkar SauravMaheshkar deleted the saurav/ci-poetry-cache branch July 12, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
2 participants