Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tools are required for attachments in openai api #14609

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

jmfallone
Copy link
Contributor

Description

Implemented the suggested changes to update the openai integration for the current openai api spec, adding a default value for tools if none are provided. Wasn't 100% sure if that would be the desired fallback, so let me know if an error should be thrown instead.

Fixes #14517

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation N/A
  • I have added Google Colab support for the newly added notebooks. N/A
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods
@jmfallone jmfallone marked this pull request as ready for review July 6, 2024 21:59
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 6, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2024
@logan-markewich logan-markewich merged commit 01a5a37 into run-llama:main Jul 12, 2024
8 checks passed
@jmfallone jmfallone deleted the obsolete-openai-api branch July 13, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
2 participants