Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vector store integration of lindorm, including knn search, … #14623

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Rainy-GG
Copy link

@Rainy-GG Rainy-GG commented Jul 8, 2024

Description

Lindorm is a cloud native multi-model database service developed by Alibaba Cloud. It allows you to store data of all sizes. Lindorm supports low-cost storage and processing of large amounts of data and the pay-as-you-go billing method. It is compatible with the open standards of multiple open source software, such as Apache HBase, Apache Cassandra, Apache Phoenix, OpenTSDB, Apache Solr, and SQL.
Here we add vector store integration with Lindorm.

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods
…legacy_search, hybrid search, search with metadatafilters, and async support. And a Rag Test Demo with LindormSearchVectorStore can be find in docs/docs/examples/vector_stores/LindormSearchDemo.ipynb.
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jul 8, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Rainy-GG Rainy-GG marked this pull request as draft July 8, 2024 10:40
@Rainy-GG Rainy-GG marked this pull request as ready for review July 8, 2024 10:41
@Rainy-GG Rainy-GG changed the title Add vector store integration of lindormsearch, including knn search, … Jul 9, 2024
…assing in filter_type when building the lindorm vector client.(all changed files have been totally tested)
…nformation and skip tests when placeholders are detected
@Rainy-GG
Copy link
Author

@logan-markewich 😊 Hi Logan~

I have fixed some coding standard issues and the unit testing errors that occurred in the workflow. Could you please review this PR and re-run the action trigger if necessary?

Thanks!🙏

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 19, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) July 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
2 participants