Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add viewport-fit to list of valid viewport directives #111

Merged
merged 7 commits into from
May 25, 2024

Conversation

Kilian
Copy link
Contributor

@Kilian Kilian commented May 15, 2024

This PR has three things:

fixes #110

@Kilian
Copy link
Contributor Author

Kilian commented May 15, 2024

Also included validation for the allowed values. I included the allowed values in the error message, which diverts from the other error messages but is more helpful.

Copy link
Owner

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Just one request, then could you also rerun the build script?

src/lib/validation.js Outdated Show resolved Hide resolved
Copy link
Owner

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again!

@rviscomi rviscomi merged commit c77da96 into rviscomi:main May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants