Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playground: FAB fabSchemeColor code for value SchemeColor.secondary is not generated. #200

Open
rydmike opened this issue Oct 15, 2023 · 0 comments
Open

Playground: FAB fabSchemeColor code for value SchemeColor.secondary is not generated. #200

rydmike opened this issue Oct 15, 2023 · 0 comments
Assignees
@rydmike
Labels
bug Something isn't working Themes Playground V8 This issue concerns version 8 and will be addressed in it
Milestone
8.0.0

Comments

@rydmike
Copy link
Owner

rydmike commented Oct 15, 2023 •
edited
Loading

When selecting SchemeColor secondary for the FAB, the config code for it is not generated.

This is remnant from when secondary was the default for both M2 and M3 mode, before M3 specs existed. Playground then left out secondary selection as it was no need to define it.

As a fix we will now only leave it out when no selection has been made (null) and add the selected color regardless of it is same as default color or not in M2 (default = secondary) or M3 (default = primaryContainer) mode. Then we do not have to figure out when it should be left out or not depending on mode.
@rydmike rydmike self-assigned this Oct 15, 2023
@rydmike rydmike added bug Something isn't working Themes Playground labels Oct 15, 2023
@rydmike rydmike added this to the 7.4.0 milestone Oct 15, 2023
rydmike added a commit that referenced this issue Oct 15, 2023
@rydmike
FIX: #200
0e8bd7a
@rydmike rydmike added the V7 This issue concerns version 7 and will be addressed in it label Oct 24, 2023
@rydmike rydmike added V8 This issue concerns version 8 and will be addressed in it and removed V7 This issue concerns version 7 and will be addressed in it labels Apr 26, 2024
@rydmike rydmike modified the milestones: 7.4.0, 8.0.0 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Themes Playground V8 This issue concerns version 8 and will be addressed in it
1 participant
@rydmike