-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Unhardcoded wait timeout for minion refresh event #61386
base: master
Are you sure you want to change the base?
Conversation
6a46c3d
to
9479da6
Compare
A similar feature was implemented for pillar: #56881 |
9479da6
to
0c7735d
Compare
@whytewolf almost forgot re this PR, I didn't have time to write a test so I add WIP and didn't expect it to be noticed. |
01e0d7f
to
3b531b1
Compare
awesome. when you do get time to add a test all we would need is one that tests that the wait argument is indeed changed when a timeout is supplied. |
No idea, I tried to setup dev env on a new MacBook and I failed. It installs half of the internet, some libs are absent I honestly have no idea why it's so heavy just to run black and isort? I guess the docs part is complicated and I'd suggest splitting pre-commit to the necessary and full or something. |
it isn't just black, isort and lint. the heaviest part of pre-commit is actually the requisite checking. which is why it pulls down everything to make sure it knows what gets pulled down. this includes every requisite needed to run tests. which is needed to make sure the test environments are not broken and have every lib needed to run the tests. Also, currently I don't think salt supports M1 based macs so that might be one of the reasons you might be having trouble. |
3b531b1
to
73b6b8d
Compare
What does this PR do?
Unhardcoded wait timeout for minion refresh event
What issues does this PR fix or reference?
Partially Fixes: #20590
Previous Behavior
Timeout was hardcoded to 30 seconds
New Behavior
Timeout is 30 seconds by default but will be overridden if
timeout
argument was passed insaltutil.refresh_pillar
for example.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes