-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Permalink
Loading
Choose a base ref
{{ refName }}
default
Loading
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: shaka-project/shaka-player
base: 96c3219
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: shaka-project/shaka-player
compare: b292ff6
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 11 commits
- 19 files changed
- 6 contributors
Commits on Jun 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5e612c9 - Browse repository at this point
Copy the full SHA 5e612c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a3f6ae - Browse repository at this point
Copy the full SHA 1a3f6aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ed9bc7 - Browse repository at this point
Copy the full SHA 2ed9bc7View commit details -
fix(preload): Fix memory leak with preload feature (#6894)
There was a memory leak where the segments that the PreloadManager prefetched did not get cleaned up, after the player unloads. This fixes that memory leak. Fixes #6883
Configuration menu - View commit details
-
Copy full SHA for 6f39210 - Browse repository at this point
Copy the full SHA 6f39210View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8ddefb - Browse repository at this point
Copy the full SHA f8ddefbView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc888bd - Browse repository at this point
Copy the full SHA dc888bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f8066e - Browse repository at this point
Copy the full SHA 3f8066eView commit details -
chore(demo): fix pattern to allow <1 decimals if can't be zero (#6903)
If an input in the demo can't be zero and a value <1 was given, the check pattern would fail for it, and it'll show the warning that the input isn't valid even though it is valid. This slightly simplifies the regex creation as canBeZero adds `0+|` to the pattern and the main pattern `([0-9]*[1-9][0-9]*)` is always used. Then, if it can be a decimal, it uses the existing pattern but adds `?(0(?=\.))?'` which makes the main pattern optional and instead adds the optionally a `0` but only if it is followed by a `.`. The main pattern `([0-9]*[1-9][0-9]*)` potentially could be simplified into `[1-9]\d*` but it would make leading zeros invalid. --------- Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 24f1af4 - Browse repository at this point
Copy the full SHA 24f1af4View commit details -
fix(Prefetch): cache iterator to avoid precision issues (#6899)
Starts caching `SegmentIterator` in `SegmentPrefetch` to avoid creating new one on every update. Previous behavior was more time-consuming & could cause issues on platforms with precision problems, like Xbox.
Configuration menu - View commit details
-
Copy full SHA for dd3b20e - Browse repository at this point
Copy the full SHA dd3b20eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dcb24b - Browse repository at this point
Copy the full SHA 3dcb24bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b292ff6 - Browse repository at this point
Copy the full SHA b292ff6View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 96c3219...b292ff6