Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 11 commits
- 19 files changed
- 6 contributors
Commits on Jun 25, 2024
-
-
fix(preload): Fix memory leak with preload feature (#6894)
There was a memory leak where the segments that the PreloadManager prefetched did not get cleaned up, after the player unloads. This fixes that memory leak. Fixes #6883
-
-
-
chore(demo): fix pattern to allow <1 decimals if can't be zero (#6903)
If an input in the demo can't be zero and a value <1 was given, the check pattern would fail for it, and it'll show the warning that the input isn't valid even though it is valid. This slightly simplifies the regex creation as canBeZero adds `0+|` to the pattern and the main pattern `([0-9]*[1-9][0-9]*)` is always used. Then, if it can be a decimal, it uses the existing pattern but adds `?(0(?=\.))?'` which makes the main pattern optional and instead adds the optionally a `0` but only if it is followed by a `.`. The main pattern `([0-9]*[1-9][0-9]*)` potentially could be simplified into `[1-9]\d*` but it would make leading zeros invalid. --------- Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
-
fix(Prefetch): cache iterator to avoid precision issues (#6899)
Starts caching `SegmentIterator` in `SegmentPrefetch` to avoid creating new one on every update. Previous behavior was more time-consuming & could cause issues on platforms with precision problems, like Xbox.
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.9.9...v4.9.10