Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font family mapping in UITextDisplayer #4749

Closed
Robloche opened this issue Nov 23, 2022 · 3 comments · Fixed by #4801
Closed

Font family mapping in UITextDisplayer #4749

Robloche opened this issue Nov 23, 2022 · 3 comments · Fixed by #4801
Assignees
@avelad
Labels
component: TTML The issue involves TTML subtitles specifically component: UI The issue involves the Shaka Player UI flag: good first issue This might be a relatively easy issue; good for new contributors flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.4

Comments

@Robloche
Copy link
Contributor

Robloche commented Nov 23, 2022 •
edited
Loading

According to the specifications tts:fontFamily and <genericFamilyName>, I understand that when the font family is a generic name, a mapping should be applied.

What I saw during one of my tests is that tts:fontFamily="proportionalSansSerif" is simply converted to font-family: proportionalSansSerif;, and since this font doesn't exist (at least to my knowledge), it produces the wrong display.

Example:
image

Did I get it right?
@Robloche Robloche added the type: question A question from the community label Nov 23, 2022
@joeyparrish
Copy link
Member

Sounds right to me. Please feel free to send a PR. Thanks!
@joeyparrish joeyparrish added type: bug Something isn't working correctly component: TTML The issue involves TTML subtitles specifically component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this flag: good first issue This might be a relatively easy issue; good for new contributors and removed type: question A question from the community labels Dec 8, 2022
@github-actions github-actions bot added this to the v4.4 milestone Dec 8, 2022
@avelad
Copy link
Collaborator

avelad commented Dec 8, 2022

See https://github.com/sandflow/imscJS/blob/master/src/main/js/html.js#L1394
@avelad avelad self-assigned this Dec 8, 2022
@avelad avelad mentioned this issue Dec 8, 2022
Merged
theodab pushed a commit that referenced this issue Dec 8, 2022
@avelad
fix(TTML): Add font-family mapping (#4801)
db8987d 
Closes #4749
joeyparrish pushed a commit that referenced this issue Dec 8, 2022
@avelad @joeyparrish
fix(TTML): Add font-family mapping (#4801)
57780dd 
Closes #4749
joeyparrish pushed a commit that referenced this issue Dec 8, 2022
@avelad @joeyparrish
fix(TTML): Add font-family mapping (#4801)
9262f92 
Closes #4749
joeyparrish pushed a commit that referenced this issue Dec 8, 2022
@avelad @joeyparrish
fix(TTML): Add font-family mapping (#4801)
7e93455 
Closes #4749
joeyparrish pushed a commit that referenced this issue Dec 8, 2022
@avelad @joeyparrish
fix(TTML): Add font-family mapping (#4801)
3827873 
Closes #4749
@Robloche
Copy link
Contributor Author

Robloche commented Dec 9, 2022

Thanks for the fix @avelad!
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Feb 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Feb 8, 2023
@avelad
fix(TTML): Add font-family mapping (shaka-project#4801)
7624a34 
Closes shaka-project#4749
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: TTML The issue involves TTML subtitles specifically component: UI The issue involves the Shaka Player UI flag: good first issue This might be a relatively easy issue; good for new contributors flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
3 participants
@joeyparrish @avelad @Robloche