Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags in the webvtt subtitle are not parsed #4956

Closed
Peterdoo opened this issue Feb 2, 2023 · 1 comment · Fixed by #4960
Closed

Tags in the webvtt subtitle are not parsed #4956

Peterdoo opened this issue Feb 2, 2023 · 1 comment · Fixed by #4960
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.4

Comments

@Peterdoo
Copy link

Peterdoo commented Feb 2, 2023 •
edited
Loading

Have you read the FAQ and checked for duplicate open issues?
YES

What version of Shaka Player are you using?
v4.3.4-uncompiled

Can you reproduce the issue with our latest release version?
YES

Can you reproduce the issue with the latest code from main?

Are you using the demo app or your own custom app?
Demo app shaka-player-demo.appspot.com

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Chrome Version 109.0.5414.120 (Official Build) (64-bit) on Win11

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

Demo app shaka-player-demo.appspot.com

What did you do?

Played a HLS video with the following cue in the webvtt file:
10:00:00.000 --> 10:00:04.000 line:90%,end position:50%
First line is <u>underlined </u>and left positioned.
Second line is <i>italic </i>&amp; moved right.
Third line is right justified and unjustif.

What did you expect to happen?
The tags should have been parsed. The two words inside the spans should be displayed underlined or italic.

What actually happened?

Tags stayed unparsed. The tags were displayed as text instead of being parsed and using them for text formatting.

This is how it looks like:
image
@Peterdoo Peterdoo added the type: bug Something isn't working correctly label Feb 2, 2023
@github-actions github-actions bot added this to the v4.4 milestone Feb 2, 2023
@avelad avelad added priority: P1 Big impact or workaround impractical; resolve before feature release component: WebVTT The issue involves WebVTT subtitles specifically labels Feb 3, 2023
@avelad avelad mentioned this issue Feb 3, 2023
Merged
@avelad
Copy link
Collaborator

avelad commented Feb 3, 2023

@Peterdoo I created #4960
avelad added a commit that referenced this issue Feb 3, 2023
@avelad
fix(WebVTT): Tags in the WebVTT subtitle are not parsed (#4960)
d4fc54f 
Fixes #4956
joeyparrish pushed a commit that referenced this issue Feb 9, 2023
@avelad @joeyparrish
fix(WebVTT): Tags in the WebVTT subtitle are not parsed (#4960)
542883f 
Fixes #4956
joeyparrish pushed a commit that referenced this issue Feb 9, 2023
@avelad @joeyparrish
fix(WebVTT): Tags in the WebVTT subtitle are not parsed (#4960)
15afb4b 
Fixes #4956
joeyparrish pushed a commit that referenced this issue Feb 9, 2023
@avelad @joeyparrish
fix(WebVTT): Tags in the WebVTT subtitle are not parsed (#4960)
933ee78 
Fixes #4956
joeyparrish pushed a commit that referenced this issue Feb 9, 2023
@avelad @joeyparrish
fix(WebVTT): Tags in the WebVTT subtitle are not parsed (#4960)
7f23b09 
Fixes #4956
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Apr 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
2 participants
@avelad @Peterdoo