Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WebVTT): Tags in the WebVTT subtitle are not parsed #4960

Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix(WebVTT): Tags in the WebVTT subtitle are not parsed #4960

merged 1 commit into from
Feb 3, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Feb 3, 2023

Fixes #4956
@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: WebVTT The issue involves WebVTT subtitles specifically labels Feb 3, 2023
@avelad avelad added this to the v4.4 milestone Feb 3, 2023
@avelad avelad mentioned this pull request Feb 3, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Incremental code coverage: 100.00%
@avelad avelad merged commit d4fc54f into shaka-project:main Feb 3, 2023
@github-actions github-actions bot mentioned this pull request Feb 3, 2023
Merged
@avelad avelad deleted the webvtt-payload branch February 3, 2023 10:14
joeyparrish pushed a commit that referenced this pull request Feb 9, 2023
@avelad @joeyparrish
fix(WebVTT): Tags in the WebVTT subtitle are not parsed (#4960)
542883f 
Fixes #4956
joeyparrish pushed a commit that referenced this pull request Feb 9, 2023
@avelad @joeyparrish
fix(WebVTT): Tags in the WebVTT subtitle are not parsed (#4960)
15afb4b 
Fixes #4956
joeyparrish pushed a commit that referenced this pull request Feb 9, 2023
@avelad @joeyparrish
fix(WebVTT): Tags in the WebVTT subtitle are not parsed (#4960)
933ee78 
Fixes #4956
joeyparrish pushed a commit that referenced this pull request Feb 9, 2023
@avelad @joeyparrish
fix(WebVTT): Tags in the WebVTT subtitle are not parsed (#4960)
7f23b09 
Fixes #4956
This was referenced Feb 9, 2023
Merged
Merged
Merged
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
2 participants
@avelad @littlespex