Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video error (code 3016) when trying to play DASH stream on Tizen with config.streaming.preferNativeHls set to true. #5166

Closed
zangue opened this issue Apr 21, 2023 · 1 comment · Fixed by #5167
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@zangue
Copy link
Contributor

zangue commented Apr 21, 2023

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.2.4

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Custom app

If custom app, can you reproduce the issue using our demo app?
Not sure

What browser and OS are you using?
Tizen 6

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Model: GU43AU8079UXZG, firmware version: N/A

What are the manifest and license server URIs?

Any DASH manifest.

What configuration are you using? What is the output of player.getConfiguration()?

What did you do?

  1. Embed shaka player in a simple tizen app
  2. Make sure the player is configured with streaming.preferNativeHls set to true
  3. Load a DASH manifest

What did you expect to happen?
Content to start playing

What actually happened?

Player crashed and threw a critical shaka.util.Error.VIDEO_ERROR error.

@zangue zangue added the type: bug Something isn't working correctly label Apr 21, 2023
@zangue
Copy link
Contributor Author

zangue commented Apr 21, 2023

According to my investigations this issue is happening because the player tries to load the DASH stream natively (src= load mode). I could trace back to root cause of this issue to a bug in the in implementation of shouldUseSrcEquals_ in player.js:
Whenever streaming.preferNativeHls is set to true, shouldUseSrcEquals_ will always return true regardless of the stream type if HTMLMediaElement.canPlayType returns a non-empty string (which is the case on tizen - it returns ‘maybe’ for DASH mime type).
To fix this we should make sure streaming.preferNativeHls config only applies to HLS stream types. I'm working on a PR to address this.

@github-actions github-actions bot added this to the v4.4 milestone Apr 21, 2023
zangue added a commit to zangue/shaka-player that referenced this issue Apr 21, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jun 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
1 participant