Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERIOD_FLATTENING_FAILED error with shaka 4.3.4 that did not occur with shaka 3.1.2 #5183

Closed
caridley opened this issue Apr 26, 2023 · 1 comment · Fixed by #5188
Closed

PERIOD_FLATTENING_FAILED error with shaka 4.3.4 that did not occur with shaka 3.1.2 #5183

caridley opened this issue Apr 26, 2023 · 1 comment · Fixed by #5188
Labels
component: DASH The issue involves the MPEG DASH manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.4

Comments

@caridley
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
4.3.4

Can you reproduce the issue with our latest release version?
Yes 4.3.5

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Chrome 112.0.5615.137 on Mac OS 13.3.1

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?
In this case the manifest file alone is sufficient to reproduce the problem when running the shaka demo app locally.
I copied the manifest into the root shaka-player folder, served that folder with the node http-server and played the stream with

http://127.0.0.1:8080/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=http://127.0.0.1:8080/manifest-with-period-flattening-error.mpd;panel=HOME;build=uncompiled

manifest-with-period-flattening-error.mpd.txt

What configuration are you using? What is the output of player.getConfiguration()?
configuration was not customized at all

What did you do?
Try to play the stream

What did you expect to happen?
Expect manifest parsing and flattening to complete without error.

What actually happened?
With shaka 4.3.4 and more recent I get the error [Shaka Error MANIFEST.PERIOD_FLATTENING_FAILED ()]

This problem does not occur with shaka 3.1.2

periodFlatteningConsoleErrror
@caridley caridley added the type: bug Something isn't working correctly label Apr 26, 2023
@github-actions github-actions bot added this to the v4.4 milestone Apr 26, 2023
@avelad avelad added the component: DASH The issue involves the MPEG DASH manifest format label Apr 26, 2023
@caridley
Copy link
Contributor Author

We have identified the cause and will submit a PR to fix it.
@caridley caridley mentioned this issue Apr 26, 2023
Merged
joeyparrish pushed a commit that referenced this issue Apr 26, 2023
@caridley
fix: PERIOD_FLATTENING_FAILED error with shaka 4.3.4 that did not occ…
e855326 
…ur with shaka 3.1.2 #5183  (#5188)

Fixed handling of manifest with new codecs in later periods by adding
check for empty matchedStreams array in createNewOutputStrems()

Fixes #5183
@github-actions github-actions bot mentioned this issue Apr 26, 2023
Merged
joeyparrish pushed a commit that referenced this issue Apr 27, 2023
@caridley @joeyparrish
fix: PERIOD_FLATTENING_FAILED error with shaka 4.3.x that did not occ…
a180b28 
…ur with shaka 3.1.2 (#5188)

Fixed handling of manifest with new codecs in later periods by adding
check for empty matchedStreams array in createNewOutputStrems()

Fixes #5183
@github-actions github-actions bot mentioned this issue Apr 27, 2023
Merged
joeyparrish pushed a commit that referenced this issue Apr 27, 2023
@caridley @joeyparrish
fix: PERIOD_FLATTENING_FAILED error with shaka 4.2.x that did not occ…
e26d19e 
…ur with shaka 3.1.2 (#5188)

Fixed handling of manifest with new codecs in later periods by adding
check for empty matchedStreams array in createNewOutputStrems()

Fixes #5183
@github-actions github-actions bot mentioned this issue Apr 27, 2023
Merged
joeyparrish pushed a commit that referenced this issue Apr 27, 2023
@caridley @joeyparrish
fix: PERIOD_FLATTENING_FAILED error with shaka 3.3.x that did not occ…
2cefcf4 
…ur with shaka 3.1.2 (#5188)

Fixed handling of manifest with new codecs in later periods by adding
check for empty matchedStreams array in createNewOutputStrems()

Fixes #5183
@github-actions github-actions bot mentioned this issue Apr 27, 2023
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jun 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: DASH The issue involves the MPEG DASH manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
2 participants
@caridley @avelad