CMCD: Regression: Rebuffering event (bs) is triggered on every subsequent Player.load()

[xsp12345]

Have you read the FAQ and checked for duplicate open issues?
yes

If the problem is related to FairPlay, have you read the tutorial?

no

What version of Shaka Player are you using?

4.9.4

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from main?
yes

Are you using the demo app or your own custom app?
custom app

If custom app, can you reproduce the issue using our demo app?
yes

What browser and OS are you using?
Firefox 126

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

Any video in https://shaka-player-demo.appspot.com/demo/#build=uncompiled

What configuration are you using? What is the output of player.getConfiguration()?

cmcd: { enabled: true }

What did you do?

Go to the Demo player,
enable CMCD
Press PLAY on any of the demo videos twice or multiple times

What did you expect to happen?
CMCD data of the video segments does not contain "bs" when the video is initially loading

What actually happened?

The first video load does not contain "bs" in the video segment's URL.
Every time you load a new video with the same shaka player instance, it adds "bs" to the CMCD data of the video segments while the video is loading.

Previously I used shaka 4.3.15. It did not have this bug.
In 4.3.15 a new instance of CmcdManager was created when the Player.load() function is called.
In the current version, 4.9.4, CmcdManager is only created once inside Player's constructor.

When a new instance of CmcdManager is created, it has the playbackStarted_ variable set to false. This is needed for the CmcdManager.setBuffering() function to dismiss any buffering events while the video is being loaded.

Thoughts on how to fix this: Player.load() could somehow reset cmcdManager's playbackStarted_ variable to false.

Are you planning send a PR to fix it?
No