Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoCorrectDrift regression with certain live streams #6963

Closed
willdharris opened this issue Jul 1, 2024 · 0 comments · Fixed by #6970
Closed

autoCorrectDrift regression with certain live streams #6963

willdharris opened this issue Jul 1, 2024 · 0 comments · Fixed by #6970
Assignees
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Milestone

Comments

@willdharris
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
yes

If the problem is related to FairPlay, have you read the tutorial?

n/a

What version of Shaka Player are you using?

4.10.0 and main

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from main?
yes

Are you using the demo app or your own custom app?
custom

If custom app, can you reproduce the issue using our demo app?
yes

What browser and OS are you using?
Chrome Version 126.0.6478.127
macOS Ventura Version 13.6

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
n/a

What are the manifest and license server URIs?

can provide via email

What configuration are you using? What is the output of player.getConfiguration()?

default config

What did you do?

Same issue as #4944

When playing a simulated live stream*, the auto correct drift functionality uses segments ahead of the live edge in its calculations. This is because the current content period is published and available, but the live edge is somewhere in the middle of the period. Using the period's segment template the auto correct calculation uses segments that are "in the future" which results in a negative presentationStartTime. This then incorrectly moves the calculated live edge to the end of the period. The issue does not occur when manifest.dash.autoCorrectDrift is set to false.

*A live stream created by stitching together VOD assets and ad periods.

What did you expect to happen?
The live edge should be the same regardless of the manifest.dash.autoCorrectDrift's value.

What actually happened?

The live edge is calculated "in the future", resulting in stalled playback.

Are you planning send a PR to fix it?
yes

@willdharris willdharris added the type: bug Something isn't working correctly label Jul 1, 2024
@shaka-bot shaka-bot added this to the v4.11 milestone Jul 1, 2024
@avelad avelad added the priority: P1 Big impact or workaround impractical; resolve before feature release label Jul 1, 2024
@avelad avelad closed this as completed in 62881f6 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
3 participants