Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix HEAD request exception #5194

Merged
merged 1 commit into from
Apr 27, 2023
Merged

fix: Fix HEAD request exception #5194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Fix HEAD request exception 
We should not look for response data in a HEAD request.

Fixes #5164
  • Loading branch information
@joeyparrish
joeyparrish committed Apr 27, 2023
commit 63d98baa1076947d87350ef8d26e5d9c1dcdb821
1 change: 1 addition & 0 deletions lib/net/networking_engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ shaka.net.NetworkingEngine = class extends shaka.util.FakeEventTarget {
if (!responseAndGotProgress.gotProgress &&
this.onProgressUpdated_ &&
!response.fromCache &&
request.method != 'HEAD' &&
type == shaka.net.NetworkingEngine.RequestType.SEGMENT) {
this.onProgressUpdated_(response.timeMs, response.data.byteLength);
}
Expand Down