Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): Remove copyStyleSheets #5273

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

beaufortfrancois
Copy link
Contributor

Document Picture-in-Picture API owners are removing copyStyleSheets option as it can be done in JavaScript. This PR removes this option and copy all style sheets internally to the PiP window.

Please review.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Incremental code coverage: 8.70%

@avelad avelad changed the title Remove copyStyleSheets Jun 9, 2023
@avelad avelad added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent labels Jun 9, 2023
@avelad avelad added this to the v4.4 milestone Jun 9, 2023
@avelad avelad changed the title feat(UI):Remove copyStyleSheets Jun 9, 2023
@theodab theodab merged commit fe43ed3 into shaka-project:main Jun 12, 2023
16 of 24 checks passed
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
3 participants